mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/templates/repo/diff/conversations.tmpl

4 lines
96 B
Go HTML Template
Raw Normal View History

[BUG] split code conversations in diff tab (#2306) Follow-up of #2282 and #2296 (which tried to address #2278) One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated). To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding). Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 13:16:11 +01:00
{{range .conversations}}
{{template "repo/diff/conversation" dict "." $ "comments" .}}
{{end}}