2021-01-21 15:51:52 +01:00
|
|
|
<form class="ui comment form stackable grid" id="new-issue" action="{{.Link}}" method="post">
|
2015-12-07 23:30:52 +01:00
|
|
|
{{.CsrfTokenHtml}}
|
|
|
|
|
{{if .Flash}}
|
|
|
|
|
<div class="sixteen wide column">
|
|
|
|
|
{{template "base/alert" .}}
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
<div class="twelve wide column">
|
2015-08-09 09:23:02 +02:00
|
|
|
<div class="ui comments">
|
2015-12-07 23:30:52 +01:00
|
|
|
<div class="comment">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 14:37:34 +01:00
|
|
|
{{template "shared/user/avatarlink" Dict "Context" $.Context "user" .SignedUser}}
|
2015-12-07 23:30:52 +01:00
|
|
|
<div class="ui segment content">
|
|
|
|
|
<div class="field">
|
2022-06-27 22:58:46 +02:00
|
|
|
<input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" tabindex="3" autofocus required maxlength="255" autocomplete="off">
|
2018-08-13 21:04:39 +02:00
|
|
|
{{if .PageIsComparePull}}
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="title_wip_desc" data-wip-prefixes="{{Json .PullRequestWorkInProgressPrefixes}}">{{.locale.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</div>
|
2018-08-13 21:04:39 +02:00
|
|
|
{{end}}
|
2015-12-07 23:30:52 +01:00
|
|
|
</div>
|
2015-08-12 12:44:09 +02:00
|
|
|
{{template "repo/issue/comment_tab" .}}
|
2015-12-07 23:30:52 +01:00
|
|
|
<div class="text right">
|
2022-05-07 14:24:02 +02:00
|
|
|
<button class="ui green button loading-button" tabindex="6">
|
2015-08-31 09:24:28 +02:00
|
|
|
{{if .PageIsComparePull}}
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.pulls.create"}}
|
2015-08-31 09:24:28 +02:00
|
|
|
{{else}}
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.create"}}
|
2015-08-31 09:24:28 +02:00
|
|
|
{{end}}
|
2015-08-09 19:04:23 +02:00
|
|
|
</button>
|
2015-12-07 23:30:52 +01:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-09 09:23:02 +02:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-09 19:04:23 +02:00
|
|
|
|
2015-08-09 09:23:02 +02:00
|
|
|
<div class="four wide column">
|
|
|
|
|
<div class="ui segment metas">
|
2017-08-24 14:30:27 +02:00
|
|
|
{{template "repo/issue/branch_selector_field" .}}
|
|
|
|
|
|
2015-08-10 12:57:57 +02:00
|
|
|
<input id="label_ids" name="label_ids" type="hidden" value="{{.label_ids}}">
|
2023-03-12 21:39:56 +01:00
|
|
|
{{template "repo/issue/labels/labels_selector_field" .}}
|
2023-03-02 18:44:06 +01:00
|
|
|
{{template "repo/issue/labels/labels_sidebar" dict "root" $}}
|
2015-08-10 12:57:57 +02:00
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
|
|
<input id="milestone_id" name="milestone_id" type="hidden" value="{{.milestone_id}}">
|
2020-04-04 07:39:48 +02:00
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-milestone dropdown">
|
2015-08-09 09:23:02 +02:00
|
|
|
<span class="text">
|
2022-06-27 22:58:46 +02:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.milestone"}}</strong>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
2020-09-11 22:19:00 +02:00
|
|
|
{{svg "octicon-gear"}}
|
2020-04-04 07:39:48 +02:00
|
|
|
{{end}}
|
2015-08-09 09:23:02 +02:00
|
|
|
</span>
|
2015-12-07 23:30:52 +01:00
|
|
|
<div class="menu">
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_milestone_title"}}</div>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{if or .OpenMilestones .ClosedMilestones}}
|
|
|
|
|
<div class="ui icon search input">
|
2023-02-13 18:59:59 +01:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-27 22:58:46 +02:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_milestones"}}">
|
2020-04-04 07:39:48 +02:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_milestone"}}</div>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{if and (not .OpenMilestones) (not .ClosedMilestones)}}
|
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.no_items"}}
|
2015-12-07 23:30:52 +01:00
|
|
|
</div>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{else}}
|
|
|
|
|
{{if .OpenMilestones}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.open_milestone"}}
|
2020-04-04 07:39:48 +02:00
|
|
|
</div>
|
|
|
|
|
{{range .OpenMilestones}}
|
2020-11-29 07:22:04 +01:00
|
|
|
<a class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}">
|
2023-02-13 18:59:59 +01:00
|
|
|
{{svg "octicon-milestone" 16 "gt-mr-2"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
{{.Name}}
|
|
|
|
|
</a>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{end}}
|
2015-12-07 23:30:52 +01:00
|
|
|
{{end}}
|
2020-04-04 07:39:48 +02:00
|
|
|
{{if .ClosedMilestones}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.closed_milestone"}}
|
2020-04-04 07:39:48 +02:00
|
|
|
</div>
|
|
|
|
|
{{range .ClosedMilestones}}
|
2020-11-29 07:22:04 +01:00
|
|
|
<a class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}">
|
2023-02-13 18:59:59 +01:00
|
|
|
{{svg "octicon-milestone" 16 "gt-mr-2"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
{{.Name}}
|
|
|
|
|
</a>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{end}}
|
2015-12-07 23:30:52 +01:00
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
2015-08-09 09:23:02 +02:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-10 12:57:57 +02:00
|
|
|
<div class="ui select-milestone list">
|
2023-02-19 05:06:14 +01:00
|
|
|
<span class="no-select item {{if .Milestone}}gt-hidden{{end}}">{{.locale.Tr "repo.issues.new.no_milestone"}}</span>
|
2015-08-10 12:57:57 +02:00
|
|
|
<div class="selected">
|
|
|
|
|
{{if .Milestone}}
|
2020-11-29 07:22:04 +01:00
|
|
|
<a class="item muted sidebar-item-link" href="{{.RepoLink}}/issues?milestone={{.Milestone.ID}}">
|
2023-02-13 18:59:59 +01:00
|
|
|
{{svg "octicon-milestone" 18 "gt-mr-3"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
{{.Milestone.Name}}
|
|
|
|
|
</a>
|
2015-08-10 12:57:57 +02:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2015-08-09 09:23:02 +02:00
|
|
|
</div>
|
2015-08-10 12:57:57 +02:00
|
|
|
|
2020-08-17 05:07:38 +02:00
|
|
|
{{if .IsProjectsEnabled}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
|
|
<input id="project_id" name="project_id" type="hidden" value="{{.project_id}}">
|
|
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-project dropdown">
|
2020-11-29 07:22:04 +01:00
|
|
|
<span class="text">
|
2022-06-27 22:58:46 +02:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.projects"}}</strong>
|
2020-11-29 07:22:04 +01:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
|
|
|
|
{{svg "octicon-gear"}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_project_title"}}</div>
|
2020-11-29 07:22:04 +01:00
|
|
|
{{if or .OpenProjects .ClosedProjects}}
|
|
|
|
|
<div class="ui icon search input">
|
2023-02-13 18:59:59 +01:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-27 22:58:46 +02:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_projects"}}">
|
2020-11-29 07:22:04 +01:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_projects"}}</div>
|
2020-11-29 07:22:04 +01:00
|
|
|
{{if and (not .OpenProjects) (not .ClosedProjects)}}
|
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.no_items"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</div>
|
|
|
|
|
{{else}}
|
|
|
|
|
{{if .OpenProjects}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.open_projects"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</div>
|
|
|
|
|
{{range .OpenProjects}}
|
2023-03-06 17:32:56 +01:00
|
|
|
<a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link}}">
|
2023-03-19 13:44:48 +01:00
|
|
|
{{svg .IconName 18 "gt-mr-3"}}{{.Title}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{if .ClosedProjects}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.closed_projects"}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</div>
|
|
|
|
|
{{range .ClosedProjects}}
|
2023-03-06 17:32:56 +01:00
|
|
|
<a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link}}">
|
2023-03-19 13:44:48 +01:00
|
|
|
{{svg .IconName 18 "gt-mr-3"}}{{.Title}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2020-08-17 05:07:38 +02:00
|
|
|
</div>
|
|
|
|
|
<div class="ui select-project list">
|
2023-02-19 05:06:14 +01:00
|
|
|
<span class="no-select item {{if .Project}}gt-hidden{{end}}">{{.locale.Tr "repo.issues.new.no_projects"}}</span>
|
2020-11-29 07:22:04 +01:00
|
|
|
<div class="selected">
|
|
|
|
|
{{if .Project}}
|
2023-03-06 17:32:56 +01:00
|
|
|
<a class="item muted sidebar-item-link" href="{{.Project.Link}}">
|
2023-03-19 13:44:48 +01:00
|
|
|
{{svg .Project.IconName 18 "gt-mr-3"}}{{.Project.Title}}
|
2020-11-29 07:22:04 +01:00
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2020-08-17 05:07:38 +02:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-08-10 15:47:23 +02:00
|
|
|
<div class="ui divider"></div>
|
2018-05-09 18:29:04 +02:00
|
|
|
<input id="assignee_ids" name="assignee_ids" type="hidden" value="{{.assignee_ids}}">
|
2020-04-04 07:39:48 +02:00
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-assignees dropdown">
|
2018-05-09 18:29:04 +02:00
|
|
|
<span class="text">
|
2022-06-27 22:58:46 +02:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.assignees"}}</strong>
|
2020-04-04 07:39:48 +02:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
2020-09-11 22:19:00 +02:00
|
|
|
{{svg "octicon-gear"}}
|
2020-04-04 07:39:48 +02:00
|
|
|
{{end}}
|
2018-05-09 18:29:04 +02:00
|
|
|
</span>
|
|
|
|
|
<div class="filter menu" data-id="#assignee_ids">
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_assignees_title"}}</div>
|
2020-04-04 07:39:48 +02:00
|
|
|
<div class="ui icon search input">
|
2023-02-13 18:59:59 +01:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-27 22:58:46 +02:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_assignees"}}">
|
2020-04-04 07:39:48 +02:00
|
|
|
</div>
|
2022-06-27 22:58:46 +02:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_assignees"}}</div>
|
2018-05-09 18:29:04 +02:00
|
|
|
{{range .Assignees}}
|
2020-11-29 07:22:04 +01:00
|
|
|
<a class="item muted" href="#" data-id="{{.ID}}" data-id-selector="#assignee_{{.ID}}">
|
2020-09-11 22:19:00 +02:00
|
|
|
<span class="octicon-check invisible">{{svg "octicon-check"}}</span>
|
2018-05-09 18:29:04 +02:00
|
|
|
<span class="text">
|
2023-03-16 17:32:25 +01:00
|
|
|
{{avatar $.Context . 28 "gt-mr-3"}}{{template "repo/search_name" .}}
|
2018-05-09 18:29:04 +02:00
|
|
|
</span>
|
|
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
<div class="ui assignees list">
|
2023-02-19 05:06:14 +01:00
|
|
|
<span class="no-select item {{if .HasSelectedLabel}}gt-hidden{{end}}">
|
2022-06-27 22:58:46 +02:00
|
|
|
{{.locale.Tr "repo.issues.new.no_assignees"}}
|
2018-05-09 18:29:04 +02:00
|
|
|
</span>
|
|
|
|
|
{{range .Assignees}}
|
2023-02-19 05:06:14 +01:00
|
|
|
<a class="item gt-p-2 muted gt-hidden" id="assignee_{{.ID}}" href="{{$.RepoLink}}/issues?assignee={{.ID}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 14:37:34 +01:00
|
|
|
{{avatar $.Context . 28 "gt-mr-3 gt-vm"}}{{.GetDisplayName}}
|
2018-05-09 18:29:04 +02:00
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2022-04-28 17:45:33 +02:00
|
|
|
{{if and .PageIsComparePull (not (eq .HeadRepo.FullName .BaseCompareRepo.FullName)) .CanWriteToHeadRepo}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
<div class="inline field">
|
|
|
|
|
<div class="ui checkbox">
|
2022-06-27 22:58:46 +02:00
|
|
|
<label class="tooltip" data-content="{{.locale.Tr "repo.pulls.allow_edits_from_maintainers_desc"}}"><strong>{{.locale.Tr "repo.pulls.allow_edits_from_maintainers"}}</strong></label>
|
2023-02-13 07:09:52 +01:00
|
|
|
<input name="allow_maintainer_edit" type="checkbox" {{if .AllowMaintainerEdit}}checked{{end}}>
|
2022-04-28 17:45:33 +02:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-08-09 09:23:02 +02:00
|
|
|
</div>
|
2021-10-05 21:21:52 +02:00
|
|
|
<input type="hidden" name="redirect_after_creation" value="{{.redirect_after_creation}}">
|
2015-08-09 09:23:02 +02:00
|
|
|
</div>
|
2015-12-07 23:30:52 +01:00
|
|
|
</form>
|