mirror of
1
Fork 0

bug: require.Eventually must not test with assert

Otherwise it fails the test instead of retrying if the condition fails
at least once.
This commit is contained in:
Earl Warren 2024-11-09 00:07:18 +01:00
parent 30f795d925
commit 2541a943ce
No known key found for this signature in database
GPG Key ID: 0579CB2928A78A00
1 changed files with 1 additions and 1 deletions

View File

@ -321,7 +321,7 @@ jobs:
require.Eventually(t, func() bool {
actionRuns = make([]*actions_model.ActionRun, 0)
require.NoError(t, db.GetEngine(db.DefaultContext).Where("repo_id=?", baseRepo.ID).Find(&actionRuns))
return assert.Len(t, actionRuns, count)
return len(actionRuns) == count
}, 30*time.Second, 1*time.Second)
// verify the expected ActionRuns were created