mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

Fixed setting of wrong position (#16148)

This commit is contained in:
KN4CK3R 2021-06-14 22:42:58 +02:00 committed by GitHub
parent 15fbf23d13
commit 68503bfae6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
web_src/js/markup/tasklist.js
View File

@ -14,7 +14,10 @@ export function initMarkupTasklist() {
const checkboxes = el.querySelectorAll(`.task-list-item input[type=checkbox]`);
for (const checkbox of checkboxes) {
if (checkbox.dataset.editable) return;
if (checkbox.dataset.editable) {
return;
}
checkbox.dataset.editable = 'true';
checkbox.addEventListener('input', async () => {
const checkboxCharacter = checkbox.checked ? 'x' : ' ';
@ -22,8 +25,15 @@ export function initMarkupTasklist() {
const rawContent = container.querySelector('.raw-content');
const oldContent = rawContent.textContent;
const newContent = oldContent.substring(0, position) + checkboxCharacter + oldContent.substring(position + 1);
if (newContent === oldContent) return;
const encoder = new TextEncoder();
const buffer = encoder.encode(oldContent);
buffer.set(encoder.encode(checkboxCharacter), position);
const newContent = new TextDecoder().decode(buffer);
if (newContent === oldContent) {
return;
}
// Prevent further inputs until the request is done. This does not use the
// `disabled` attribute because it causes the border to flash on click.