mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

Fix some animation bugs (#27287) 

Fix #27286
Replace #27279
This commit is contained in:
wxiaoguang 2023-09-27 09:15:58 +08:00 committed by GitHub
parent 709c2fad8a
commit 6967c13ad2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 45 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
web_src/js/modules/fomantic.js
View File

@ -25,41 +25,55 @@ export function initGiteaFomantic() {
return escape(text, preserveHTML) + svg('octicon-x', 16, `${className.delete} icon`); return escape(text, preserveHTML) + svg('octicon-x', 16, `${className.delete} icon`);
}; };
const transitionNopBehaviors = new Set([
'clear queue', 'stop', 'stop all', 'destroy',
'force repaint', 'repaint', 'reset',
'looping', 'remove looping', 'disable', 'enable',
'set duration', 'save conditions', 'restore conditions',
]);
// stand-in for removed transition module // stand-in for removed transition module
$.fn.transition = function (arg) { $.fn.transition = function (arg0, arg1, arg2) {
if (arg === 'is supported') return true; if (arg0 === 'is supported') return true;
if (arg === 'is animating') return false; if (arg0 === 'is animating') return false;
if (arg === 'is inward') return false; if (arg0 === 'is inward') return false;
if (arg === 'is outward') return false; if (arg0 === 'is outward') return false;
if (arg === 'stop all') return;
const isIn = arg?.animation?.endsWith(' in'); let argObj;
const isOut = arg?.animation?.endsWith(' out'); if (typeof arg0 === 'string') {
// many behaviors are no-op now. https://fomantic-ui.com/modules/transition.html#/usage
let ret; if (transitionNopBehaviors.has(arg0)) return this;
if (arg === 'show' || isIn) { // now, the arg0 is an animation name, the syntax: (animation, duration, complete)
arg?.onStart?.(this); argObj = {animation: arg0, ...(arg1 && {duration: arg1}), ...(arg2 && {onComplete: arg2})};
ret = this.each((_, el) => { } else if (typeof arg0 === 'object') {
el.classList.remove('hidden'); argObj = arg0;
el.classList.add('visible'); } else {
if (isIn) el.classList.add('transition'); throw new Error(`invalid argument: ${arg0}`);
if (arg?.displayType) el.style.setProperty('display', arg.displayType, 'important');
arg?.onShow?.(this);
});
arg?.onComplete?.(this);
} else if (arg === 'hide' || isOut) {
arg?.onStart?.(this);
ret = this.each((_, el) => {
el.classList.add('hidden');
el.classList.remove('visible');
// don't remove the transition class because fomantic didn't do it either
el.style.removeProperty('display');
arg?.onHidden?.(this);
});
arg?.onComplete?.(this);
} }
return ret; const isAnimationIn = argObj.animation?.startsWith('show') || argObj.animation?.endsWith(' in');
const isAnimationOut = argObj.animation?.startsWith('hide') || argObj.animation?.endsWith(' out');
this.each((_, el) => {
let toShow = isAnimationIn;
if (!isAnimationIn && !isAnimationOut) {
// If the animation is not in/out, then it must be a toggle animation.
// Fomantic uses computed styles to check "visibility", but to avoid unnecessary arguments, here it only checks the class.
toShow = this.hasClass('hidden'); // maybe it could also check "!this.hasClass('visible')", leave it to the future until there is a real problem.
}
argObj.onStart?.call(el);
if (toShow) {
el.classList.remove('hidden');
el.classList.add('visible', 'transition');
if (argObj.displayType) el.style.setProperty('display', argObj.displayType, 'important');
argObj.onShow?.call(el);
} else {
el.classList.add('hidden');
el.classList.remove('visible'); // don't remove the transition class because the Fomantic animation style is `.hidden.transition`.
el.style.removeProperty('display');
argObj.onHidden?.call(el);
}
argObj.onComplete?.call(el);
});
return this;
}; };
initFomanticApiPatch(); initFomanticApiPatch();