[GITEA] Add slow SQL query warning (squash) Fix setting typo

- Fix typo in the slow query threshold setting, add a deprecation warning.
- Resolves #2203

(cherry picked from commit 02f6608e5f)
(cherry picked from commit 4e8f6b2ffd)

docs/content/administration/config-cheat-sheet.en-us.md

@@ -458,7 +458,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a
 - `MAX_IDLE_CONNS` **2**: Max idle database connections on connection pool, default is 2 - this will be capped to `MAX_OPEN_CONNS`.
 - `CONN_MAX_LIFETIME` **0 or 3s**: Sets the maximum amount of time a DB connection may be reused - default is 0, meaning there is no limit (except on MySQL where it is 3s - see #6804 & #7071).
 - `AUTO_MIGRATION` **true**: Whether execute database models migrations automatically.
-- `SLOW_QUERY_TRESHOLD` **5s**: Threshold value in seconds beyond which query execution time is logged as a warning in the xorm logger.
+- `SLOW_QUERY_THRESHOLD` **5s**: Threshold value in seconds beyond which query execution time is logged as a warning in the xorm logger.
 
 [^1]: It may be necessary to specify a hostport even when listening on a unix socket, as the port is part of the socket name. see [#24552](https://github.com/go-gitea/gitea/issues/24552#issuecomment-1681649367) for additional details.
 

models/db/engine.go

@@ -147,9 +147,9 @@ func InitEngine(ctx context.Context) error {
 	xormEngine.SetConnMaxLifetime(setting.Database.ConnMaxLifetime)
 	xormEngine.SetDefaultContext(ctx)
 
-	if setting.Database.SlowQueryTreshold > 0 {
+	if setting.Database.SlowQueryThreshold > 0 {
 		xormEngine.AddHook(&SlowQueryHook{
-			Treshold: setting.Database.SlowQueryTreshold,
+			Treshold: setting.Database.SlowQueryThreshold,
 			Logger:   log.GetLogger("xorm"),
 		})
 	}

modules/setting/database.go

@@ -25,27 +25,27 @@ var (
 
 	// Database holds the database settings
 	Database = struct {
-		Type              DatabaseType
+		Type               DatabaseType
-		Host              string
+		Host               string
-		Name              string
+		Name               string
-		User              string
+		User               string
-		Passwd            string
+		Passwd             string
-		Schema            string
+		Schema             string
-		SSLMode           string
+		SSLMode            string
-		Path              string
+		Path               string
-		LogSQL            bool
+		LogSQL             bool
-		MysqlCharset      string
+		MysqlCharset       string
-		CharsetCollation  string
+		CharsetCollation   string
-		Timeout           int // seconds
+		Timeout            int // seconds
-		SQLiteJournalMode string
+		SQLiteJournalMode  string
-		DBConnectRetries  int
+		DBConnectRetries   int
-		DBConnectBackoff  time.Duration
+		DBConnectBackoff   time.Duration
-		MaxIdleConns      int
+		MaxIdleConns       int
-		MaxOpenConns      int
+		MaxOpenConns       int
-		ConnMaxLifetime   time.Duration
+		ConnMaxLifetime    time.Duration
-		IterateBufferSize int
+		IterateBufferSize  int
-		AutoMigration     bool
+		AutoMigration      bool
-		SlowQueryTreshold time.Duration
+		SlowQueryThreshold time.Duration
 	}{
 		Timeout:           500,
 		IterateBufferSize: 50,
@@ -88,7 +88,13 @@ func loadDBSetting(rootCfg ConfigProvider) {
 	Database.DBConnectRetries = sec.Key("DB_RETRIES").MustInt(10)
 	Database.DBConnectBackoff = sec.Key("DB_RETRY_BACKOFF").MustDuration(3 * time.Second)
 	Database.AutoMigration = sec.Key("AUTO_MIGRATION").MustBool(true)
-	Database.SlowQueryTreshold = sec.Key("SLOW_QUERY_TRESHOLD").MustDuration(5 * time.Second)
+
+	deprecatedSetting(rootCfg, "database", "SLOW_QUERY_TRESHOLD", "database", "SLOW_QUERY_THRESHOLD", "1.23")
+	if sec.HasKey("SLOW_QUERY_TRESHOLD") && !sec.HasKey("SLOW_QUERY_THRESHOLD") {
+		Database.SlowQueryThreshold = sec.Key("SLOW_QUERY_TRESHOLD").MustDuration(5 * time.Second)
+	} else {
+		Database.SlowQueryThreshold = sec.Key("SLOW_QUERY_THRESHOLD").MustDuration(5 * time.Second)
+	}
 }
 
 // DBConnStr returns database connection string