mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

Fix review box viewport overflow issue (#23800) (#23898) 

Backport #23800 by @silverwind

Fix regression that came likely from
https://github.com/go-gitea/gitea/pull/23271:

Long lines of text currently cause the review box's CodeMirror element
to resize which apparently is not recognized by [popper's resize
detection](https://popper.js.org/docs/v2/modifiers/event-listeners/) and
which causes the element to go partially out of viewport until a reflow
happens:


![wrap](https://user-images.githubusercontent.com/115237/228673260-f8ffe89e-5724-4fb9-b93f-30b146c4c436.gif)

Fix this by setting the element to a static width derived from viewport
width and remove the previously clumsy media queries.

Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
Giteabot 2023-04-03 12:11:08 -04:00 committed by GitHub
parent 1886bd6a01
commit 847f0bb9f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
web_src/css/review.css
View File

@ -225,28 +225,10 @@ a.blob-excerpt:hover {
max-height: calc(100vh - 360px);
}
@media (max-width: 767px) {
.review-box-panel .CodeMirror-scroll {
max-width: calc(100vw - 70px);
}
}
@media (min-width: 768px) and (max-width: 991px) {
.review-box-panel .CodeMirror-scroll {
max-width: 700px;
}
}
@media (min-width: 992px) and (max-width: 1200px) {
.review-box-panel .CodeMirror-scroll {
max-width: 800px;
}
}
@media (min-width: 1201px) {
.review-box-panel .CodeMirror-scroll {
max-width: 900px;
}
.review-box-panel .editor-toolbar,
.review-box-panel .CodeMirror-scroll {
width: min(calc(100vw - 2em), 800px);
max-width: none;
}
#review-box {