mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

Remove org users who belong to no teams (#24247) 

Fix #24128

---------

Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
yp05327 2023-04-25 04:52:38 +09:00 committed by GitHub
parent fe007b65bd
commit 8cc60ee01a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
models/org_team.go
View File

@ -419,6 +419,12 @@ func DeleteTeam(t *organization.Team) error {
return err return err
} }
for _, tm := range t.Members {
if err := removeInvalidOrgUser(ctx, tm.ID, t.OrgID); err != nil {
return err
}
}
// Update organization number of teams. // Update organization number of teams.
if _, err := db.Exec(ctx, "UPDATE `user` SET num_teams=num_teams-1 WHERE id=?", t.OrgID); err != nil { if _, err := db.Exec(ctx, "UPDATE `user` SET num_teams=num_teams-1 WHERE id=?", t.OrgID); err != nil {
return err return err
@ -568,16 +574,19 @@ func removeTeamMember(ctx context.Context, team *organization.Team, userID int64
} }
} }
return removeInvalidOrgUser(ctx, userID, team.OrgID)
}
func removeInvalidOrgUser(ctx context.Context, userID, orgID int64) error {
// Check if the user is a member of any team in the organization. // Check if the user is a member of any team in the organization.
if count, err := e.Count(&organization.TeamUser{ if count, err := db.GetEngine(ctx).Count(&organization.TeamUser{
UID: userID, UID: userID,
OrgID: team.OrgID, OrgID: orgID,
}); err != nil { }); err != nil {
return err return err
} else if count == 0 { } else if count == 0 {
return removeOrgUser(ctx, team.OrgID, userID) return removeOrgUser(ctx, orgID, userID)
} }
return nil return nil
} }