mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

Fix milestone title font problem (#22863) 

Replace #22853 since it's closed, and actually there are 2 places need
to be fixed.

~~Follow @fsologureng 's suggestion to keep the `<hX>` tags.~~ 

Update: from fsologureng: this doesn't change anything from a11y's point
of view. So I think this PR could be fine to fix the UI looking problems
as a quick patch, then defer the a11y problems to new PRs together.

Before: the font-size is too large.

After: it seems better.

![image](https://user-images.githubusercontent.com/2114189/218266257-fc2d5872-9e96-4c6a-87ea-f27531ac15c0.png)

![image](https://user-images.githubusercontent.com/2114189/218266247-efc09d83-405f-4495-967a-30d9744134ce.png)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
wxiaoguang 2023-02-12 11:19:09 +08:00 committed by GitHub
parent e460b6ef4d
commit b0f18726a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
templates/repo/issue/milestones.tmpl
View File

@ -62,9 +62,9 @@
{{range .Milestones}} {{range .Milestones}}
<li class="item"> <li class="item">
<div class="df ac sb"> <div class="df ac sb">
<h2 class="df ac m-0 fw"> <h3 class="df ac m-0 fw">
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a> {{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a>
</h2> </h3>
<div class="df ac"> <div class="df ac">
<span class="mr-3">{{.Completeness}}%</span> <span class="mr-3">{{.Completeness}}%</span>
<progress value="{{.Completeness}}" max="100"></progress> <progress value="{{.Completeness}}" max="100"></progress>

4
templates/user/dashboard/milestones.tmpl
View File

@ -81,10 +81,10 @@
{{range .Milestones}} {{range .Milestones}}
<li class="item"> <li class="item">
<div class="df ac sb"> <div class="df ac sb">
<h2 class="df ac m-0 fw"> <h3 class="df ac m-0 fw">
<span class="ui large label">{{.Repo.FullName}}</span> <span class="ui large label">{{.Repo.FullName}}</span>
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{.Repo.Link}}/milestone/{{.ID}}">{{.Name}}</a> {{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{.Repo.Link}}/milestone/{{.ID}}">{{.Name}}</a>
</h2> </h3>
<div class="df ac"> <div class="df ac">
<span class="mr-3">{{.Completeness}}%</span> <span class="mr-3">{{.Completeness}}%</span>
<progress value="{{.Completeness}}" max="100"></progress> <progress value="{{.Completeness}}" max="100"></progress>