mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity

fix(sec): modify api route for variables

This commit is contained in:
Gusted 2025-01-25 15:10:03 +01:00 committed by Earl Warren
parent 3705555f67
commit caeb95cb10
No known key found for this signature in database
GPG Key ID: 0579CB2928A78A00
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
routers/api/v1/org/action.go
View File

@ -475,7 +475,7 @@ func (Action) UpdateVariable(ctx *context.APIContext) {
if opt.Name == "" { if opt.Name == "" {
opt.Name = ctx.Params("variablename") opt.Name = ctx.Params("variablename")
} }
if _, err := actions_service.UpdateVariable(ctx, v.ID, opt.Name, opt.Value); err != nil { if _, err := actions_service.UpdateVariable(ctx, v.ID, ctx.Org.Organization.ID, 0, opt.Name, opt.Value); err != nil {
if errors.Is(err, util.ErrInvalidArgument) { if errors.Is(err, util.ErrInvalidArgument) {
ctx.Error(http.StatusBadRequest, "UpdateVariable", err) ctx.Error(http.StatusBadRequest, "UpdateVariable", err)
} else { } else {

2
routers/api/v1/repo/action.go
View File

@ -414,7 +414,7 @@ func (Action) UpdateVariable(ctx *context.APIContext) {
if opt.Name == "" { if opt.Name == "" {
opt.Name = ctx.Params("variablename") opt.Name = ctx.Params("variablename")
} }
if _, err := actions_service.UpdateVariable(ctx, v.ID, opt.Name, opt.Value); err != nil { if _, err := actions_service.UpdateVariable(ctx, v.ID, 0, ctx.Repo.Repository.ID, opt.Name, opt.Value); err != nil {
if errors.Is(err, util.ErrInvalidArgument) { if errors.Is(err, util.ErrInvalidArgument) {
ctx.Error(http.StatusBadRequest, "UpdateVariable", err) ctx.Error(http.StatusBadRequest, "UpdateVariable", err)
} else { } else {

2
routers/api/v1/user/action.go
View File

@ -228,7 +228,7 @@ func UpdateVariable(ctx *context.APIContext) {
if opt.Name == "" { if opt.Name == "" {
opt.Name = ctx.Params("variablename") opt.Name = ctx.Params("variablename")
} }
if _, err := actions_service.UpdateVariable(ctx, v.ID, opt.Name, opt.Value); err != nil { if _, err := actions_service.UpdateVariable(ctx, v.ID, ctx.Doer.ID, 0, opt.Name, opt.Value); err != nil {
if errors.Is(err, util.ErrInvalidArgument) { if errors.Is(err, util.ErrInvalidArgument) {
ctx.Error(http.StatusBadRequest, "UpdateVariable", err) ctx.Error(http.StatusBadRequest, "UpdateVariable", err)
} else { } else {