ea1ff23f36
Merge pull request 'fix: Move "forgot_password"-link to fix login tab order' ( #5838 ) from mrsmoer/fix-login-taborder into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5838
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-09 22:59:50 +00:00
8587d49979
Remove unused css class "form-field-content-aside-label"
...
This css class was used to display the "forgot password"-link right and above the password field.
cd75519a0b
2024-11-09 22:59:50 +00:00
506ed7f43f
fix: Move "forgot_password"-link to fix login tab order
...
Previously hitting tab in the username field set the focus to the "forgot password" link. Only on the next hit the password field was selected.
This is an issue for some password managers (keepassdx android keyboard) and not as nice for accessibility.
Now the forgot link is below the sign up link at the bottom of the page.
Using "tabindex" didn't work properly with the templating engine because many elements get assigned a tabindex of "0" by default disrupting the tab selection sequence.
2024-11-09 22:59:50 +00:00
265fb6bd1d
Merge pull request '[THEME] Copy ansi terminal colours from gitea to forgejo themes' ( #5881 ) from RagnarGrootKoerkamp/forgejo:fix-terminal-colours into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5881
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-09 21:24:30 +00:00
e58d5d46c1
[THEME] Copy ansi terminal colours from gitea to forgejo themes
2024-11-09 21:14:31 +01:00
59926daf7f
Merge pull request '[PORT] Fix code owners will not be mentioned when a pull request comes from a forked repository (gitea#30476)' ( #5850 ) from gusted/forgejo-fix-cond-codeowners into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5850
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-11-09 18:41:50 +00:00
536e1923b4
chore: add extra integration test
2024-11-09 19:13:08 +01:00
8852f2c0ee
Merge pull request 'fix(ci): slow runners may need more than 50 minutes for a test' ( #5878 ) from earl-warren/forgejo:wip-ci-timeout into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5878
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-09 17:50:24 +00:00
39f4018d87
fix(ci): slow runners may need more than 50 minutes for a test
2024-11-09 18:16:38 +01:00
dffee135f8
Update module code.forgejo.org/go-chi/captcha to v1 (forgejo) ( #5864 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5864
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-09 07:28:23 +00:00
2efc1f5686
[PORT] Fix code owners will not be mentioned when a pull request comes from a forked repository (gitea#30476)
...
Fix #30277
Caused by #29783
---
- Resolves #5842
- Regression from #2855
(cherry picked from commit c63060b130d34e3f03f28f4dccbf04d381a95c17)
2024-11-09 00:46:48 +01:00
9a15b2be43
Merge pull request 'bug: require.Eventually must not test with assert' ( #5869 ) from earl-warren/forgejo:wip-race-test into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5869
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-08 23:41:27 +00:00
5ab832ba87
Update module code.forgejo.org/go-chi/session to v1 (forgejo) ( #5865 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5865
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-08 23:37:13 +00:00
2541a943ce
bug: require.Eventually must not test with assert
...
Otherwise it fails the test instead of retrying if the condition fails
at least once.
2024-11-09 00:07:18 +01:00
bf69683df6
Update module code.forgejo.org/go-chi/cache to v1 (forgejo) ( #5863 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5863
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-08 21:12:20 +00:00
d2a3eefcd0
Update module code.forgejo.org/go-chi/binding to v1 (forgejo) ( #5862 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5862
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-08 17:43:48 +00:00
10b90aa2d2
Merge pull request 'chore(renovate): only run if renovate workflow changed' ( #5858 ) from viceice/chore/renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5858
Reviewed-by: Otto <otto@codeberg.org>
2024-11-08 12:40:00 +00:00
2eeb2fcd35
chore(renovate): only run if renovate workflow changed
2024-11-08 13:05:43 +01:00
765405ea2a
Merge pull request 'chore(renovate): update settings' ( #5857 ) from viceice/chore/renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5857
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-08 11:22:23 +00:00
669b4b46e6
chore(renovate): pin to single actions runner
2024-11-08 12:18:29 +01:00
4f336e589d
chore(renovate): group forgejo go-chi packages
2024-11-08 12:17:00 +01:00
3a3416c069
Migrate playwright to typescript
2024-11-08 09:55:54 +01:00
30f795d925
Merge pull request '[PORT] Refactor tests to prevent from unnecessary preparations (gitea#32398)' ( #5790 ) from gusted/forgejo-port-32398 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5790
Reviewed-by: Otto <otto@codeberg.org>
2024-11-07 23:26:22 +00:00
3c4153b195
[PORT] Refactor tests to prevent from unnecessary preparations (gitea#32398)
...
Some preparations are only used by a few tests, so to make the tests fast, they should only be prepared when they are used.
By the way, this PR splits PrepareTestEnv into small functions to make it simple.
---
Conflict resolution: Mostly magical and just re-pasting the code into
the right places.
Done differently: use `require.NoError` instead of `assert.NoError`.
(cherry picked from commit ec2d1593c269e06655525deb96f74b8094221b6f)
2024-11-07 23:02:10 +01:00
5e777a43a1
Merge pull request 'fix: issue labels are not set after deleting one label' ( #5843 ) from earl-warren/forgejo:wip-unlabeled into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5843
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-07 10:36:45 +00:00
f06bdb0552
chore(refactor): split ReloadLabels out of LoadLabels in issue model
...
Functions modifying the labels in the database (DeleteIssueLabel,
NewIssueLabels, NewIssueLabel, ReplaceIssueLabels) need to force
reload them. Instead of:
issue.isLabelsLoaded = false
issue.Labels = nil
if err = issue.LoadLabels(ctx); err != nil {
return err
}
They can now use:
if err = issue.ReloadLabels(ctx); err != nil {
return err
}
2024-11-07 11:05:38 +01:00
db899c19d8
fix: issue labels are not set after deleting one label
...
Because issue.isLabelsLoaded = false is missing, LoadLabels is a noop
and the issue.Labels is nil.
2024-11-07 10:38:01 +01:00
7da6778ce1
Update dependency eslint-plugin-playwright to v2.0.1 (forgejo) ( #5837 )
...
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-07 07:52:50 +00:00
600be26638
i18n: update of translations from Codeberg Translate ( #5754 )
...
Co-authored-by: Juno Takano <jutty@users.noreply.translate.codeberg.org>
Co-authored-by: Outbreak2096 <Outbreak2096@users.noreply.translate.codeberg.org>
Co-authored-by: Benedikt Straub <Nordfriese@users.noreply.translate.codeberg.org>
Co-authored-by: Edgarsons <Edgarsons@users.noreply.translate.codeberg.org>
Co-authored-by: 0ko <0ko@users.noreply.translate.codeberg.org>
Co-authored-by: Fjuro <fjuro@alius.cz>
Co-authored-by: SomeTr <SomeTr@users.noreply.translate.codeberg.org>
Co-authored-by: Atalanttore <Atalanttore@users.noreply.translate.codeberg.org>
Co-authored-by: Anonymous <anonymous@users.noreply.translate.codeberg.org>
Co-authored-by: Dirk <Dirk@users.noreply.translate.codeberg.org>
Co-authored-by: xtex <xtexchooser@duck.com>
Co-authored-by: artnay <artnay@users.noreply.translate.codeberg.org>
Co-authored-by: WithLithum <WithLithum@users.noreply.translate.codeberg.org>
Co-authored-by: dobrvlskyi <dobrvlskyi@users.noreply.translate.codeberg.org>
Co-authored-by: earl-warren <earl-warren@users.noreply.translate.codeberg.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5754
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Codeberg Translate <translate@noreply.codeberg.org>
Co-committed-by: Codeberg Translate <translate@noreply.codeberg.org>
2024-11-07 07:22:37 +00:00
ee5d1cf876
Update dependency happy-dom to v15.11.0 (forgejo) ( #5840 )
...
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-07 06:40:27 +00:00
18cf8adc71
Merge pull request 'Update dependency go to v1.23.3 (forgejo)' ( #5836 ) from renovate/forgejo-patch-golang-packages into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5836
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-07 06:38:35 +00:00
94650c27a8
Update dependency go to v1.23.3
2024-11-07 00:03:28 +00:00
019083ed5a
Merge pull request 'Make direnv optional to let developers use their own direnv configuration' ( #5835 ) from psentee/forgejo:psentee/make-envrc-optional into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5835
Reviewed-by: Otto <otto@codeberg.org>
2024-11-06 20:31:09 +00:00
ffcf80c3a5
Make direnv optional to let developers use their own direnv configuration
2024-11-06 20:34:49 +01:00
a97ec9bd83
Merge pull request 'fix: labels are missing in the pull request payload removing a label' ( #5831 ) from earl-warren/forgejo:wip-unlabeled into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5831
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-06 17:37:07 +00:00
c801838690
fix: labels are missing in the pull request payload removing a label
...
When ReplaceIssueLabels calls issue.LoadLabels it was a noop because
issue.isLabelsLoaded is still set to true because of the call to
issue.LoadLabels that was done at the beginning of the function.
2024-11-06 16:43:14 +01:00
85ff5ecafd
Merge pull request 'chore(renovate): fix regex' ( #5832 ) from viceice/chore/renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5832
Reviewed-by: Otto <otto@codeberg.org>
2024-11-06 15:41:13 +00:00
968ca15f06
chore(renovate): fix regex
2024-11-06 15:58:44 +01:00
4e009474e0
Merge pull request 'chore(renovate): use squash for automerge' ( #5830 ) from viceice/chore/renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5830
Reviewed-by: Otto <otto@codeberg.org>
2024-11-06 14:44:48 +00:00
8bb33b2c4c
chore(renovate): use squash for automerge
...
We don't sign commits, so no benefit for a merge commit.
2024-11-06 15:42:07 +01:00
8b27dcb3b6
Update renovate to v39 (forgejo) (major) ( #5829 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5829
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-06 14:39:53 +00:00
0fb48872ac
Merge pull request '[FEAT] Trim spaces from repo names on form submission' ( #5822 ) from gusted/forgejo-trim-spaces-form into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5822
Reviewed-by: Otto <otto@codeberg.org>
2024-11-06 09:16:17 +00:00
36b18fb6cc
Merge pull request '[gitea] week 2024-45 cherry pick (gitea/main -> forgejo)' ( #5789 ) from algernon/wcp/2024-45 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5789
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-06 08:57:43 +00:00
b68c98ff3e
Merge pull request 'Update dependency happy-dom to v15.10.0 (forgejo)' ( #5825 ) from renovate/forgejo-happy-dom-15.x into forgejo
2024-11-06 08:03:09 +00:00
104a1b6fca
Update dependency happy-dom to v15.10.1
2024-11-06 02:03:49 +00:00
473270bbdb
Merge pull request 'Update dependency djlint to v1.36.0 (forgejo)' ( #5824 ) from renovate/forgejo-djlint-1.x into forgejo
2024-11-06 00:52:31 +00:00
329650a9b4
Update dependency djlint to v1.36.0
2024-11-06 00:03:27 +00:00
4952747699
[FEAT] Trim spaces from repository name
...
- This uses the `TrimSpace` preprocessing of the binding library to
remove any accidental spaces from the input.
- Integration test added.
- Resolves #4309
2024-11-05 23:13:17 +01:00
310376525b
[CHORE] Use forked `binding` library
...
- Use the forked [binding](https://code.forgejo.org/go-chi/binding )
library. This library has two benefits, it removes the usage of
`github.com/goccy/go-json` (has no benefit as the minimo library is also
using it). It adds the `TrimSpace` feature, which will during the
binding part trim the spaces around the value it got from the form, this
is done before validation.
2024-11-05 22:47:34 +01:00
f28e728317
Merge pull request '[PORT] Replace DateTime with proper functions (gitea#32402)' ( #5796 ) from gusted/forgejo-port-dateutils into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5796
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-11-05 21:46:29 +00:00
Gusted