mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
13,785 Commits 11 Branches 235 Tags 636 MiB
Commit Graph

19 Commits

Author SHA1 Message Date
Wim cb50375e2b
Add more linters to improve code readability (#19989) 
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability

- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign -  wastedassign finds wasted assignment statements.
- notlintlint -  Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
  - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
 2022-06-20 12:02:49 +02:00
KN4CK3R 3f280f89e7
Update HTTP status codes to modern codes (#18063) 
* 2xx/3xx/4xx/5xx -> http.Status...
* http.StatusFound -> http.StatusTemporaryRedirect
* http.StatusMovedPermanently -> http.StatusPermanentRedirect
 2022-03-23 12:54:07 +08:00
6543 54e9ee37a7
format with gofumpt (#18184) 
* gofumpt -w -l .

* gofumpt -w -l -extra .

* Add linter

* manual fix

* change make fmt
 2022-01-20 18:46:10 +01:00
kolaente f9ec2f89f2 Add golangci (#6418) 2019-06-12 15:41:28 -04:00
zeripath ce8de35334 Remove local clones & make hooks run on merge/edit/upload (#6672) 
* Add options to git.Clone to make it more capable

* Begin the process of removing the local copy and tidy up

* Remove Wiki LocalCopy Checkouts

* Remove the last LocalRepo helpers

* Remove WithTemporaryFile

* Enable push-hooks for these routes

* Ensure tests cope with hooks

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove Repository.LocalCopyPath()

* Move temporary repo to use the standard temporary path

* Fix the tests

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove LocalWikiPath

* Fix missing remove

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use AppURL for Oauth user link (#6894)

* Use AppURL for Oauth user link

Fix #6843

* Update oauth.go

* Update oauth.go

* internal/ssh: ignore env command totally (#6825)

* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue #6889

* Escape the commit message on issues update and title in telegram hook (#6901)

* update sdk to latest (#6903)

* improve description of branch protection (fix #6886) (#6906)

The branch protection description text were not quite accurate.

* Fix logging documentation (#6904)

* ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG

* Allow DISABLE_ROUTER_LOG to be set in the [log] section

* [skip ci] Updated translations via Crowdin

* Move sdk structs to modules/structs (#6905)

* move sdk structs to moduels/structs

* fix tests

* fix fmt

* fix swagger

* fix vendor
 2019-05-11 11:29:17 -04:00
bugreport0 bac6d05e78 Improve English grammar and consistency. (#3614) 
* Start improving English grammar and consistency.

* Apply review comments, push translation further.

* Additional review changes; expand translation.

* Undo team/organization change, further translation.

* Add site administration; review comments; merge.

* Update hardcoded branch protection string tests.

* Update hardcoded branch deletion string test.

* Update another hardcoded translation string test.

* Add my nickname to the list of translators.

* Implement @lafriks review comments.

* Remove (now) unused branch deletion warnings.

* Remove (now) unused branch deletion warnings.
 2018-04-19 17:24:31 +03:00
Ethan Koenig e59adcde65 Use httptest in integration tests (#3080) 2017-12-04 00:46:01 +02:00
Ethan Koenig 513375c429 Make URL scheme unambiguous (#2408) 
* Make URL scheme unambiguous

Redirect old routes to new routes

* Fix redirects to new URL scheme, and update template

* Fix branches/_new endpoints, and update integration test
 2017-10-30 10:04:25 +08:00
Lauris BH c7f4f07765 Integration test for activity page (#2704) 
* Integration test for activity page

* Small code refactoring for acitvity page

* Move activity stats calculation logic to model
 2017-10-16 00:54:53 +03:00
Lunny Xiao 1739e84ac0 improve protected branch to add whitelist support (#2451) 
* improve protected branch to add whitelist support

* fix lint

* fix style check

* fix tests

* fix description on UI and import

* fix test

* bug fixed

* fix tests and languages

* move isSliceInt64Eq to util pkg; improve function names & typo
 2017-09-14 16:16:22 +08:00
Ethan Koenig f1adaef458 Less verbose integration tests (#2123) 
* Helper functions for intergration test boilerplate
 2017-07-07 21:36:47 +02:00
Ethan Koenig f64c232953 Improve integration test helper functions (#2049) 
Set request headers in helper functions, and new helper for requests with string-formatted URLs
 2017-06-25 08:15:42 +08:00
Lauris BH 0a5dc640a1 Make branch deletion URL more like GitHub's, fixes #1397 (#1994) 
* Make branch deletion URL more like GitHub's, fixes #1397

* Add PR branch deletion integration test

* Do not allow deleting protected branch

* Change http error code to 403 if user has no write rights to repository

* Add check to not panic if forked repository has alrady been deleted
 2017-06-21 09:00:03 +08:00
Bo-Yi Wu 90f9bb12c6 fix golint error and rename func for suggestion. (#1997) 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
 2017-06-17 11:29:59 -05:00
Ethan Koenig ce9b86082c Consolidate boilerplate in integration tests (#1979) 2017-06-17 12:49:45 +08:00
Mura Li 01322af2e8 Add integration test for pull-request merge (#1912) 2017-06-15 19:20:39 +08:00
Ethan Koenig 61716bd8f7 Display URLs in integration test logs (#1924) 2017-06-09 19:41:36 -05:00
Mura Li 662b8bc2a2 Add integration test for file editing (#1907) 2017-06-08 19:15:41 +08:00
Lauris BH 0144817971 Do not allow commiting to protected branch from online editor (#1502) 
* Do not allow commiting to protected branch from online editor

* Add editor integration tests for adding new file and not allowing to add new file to protected branch
 2017-05-02 08:49:55 +08:00