3aa6f17e1e
Remove repetitive words ( #30091 )
...
remove repetitive words
Signed-off-by: crazeteam <lilujing@outlook.com>
(cherry picked from commit ecbc9cee2b69cd9707acb1e23ccbca048484c460)
2024-03-30 07:17:30 +01:00
c82bef515e
Migrate margin and padding helpers to tailwind ( #30043 )
...
This will conclude the refactor of 1:1 class replacements to tailwind,
except `gt-hidden`. Commands ran:
```bash
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g' {web_src/js,templates,routers,services}/**/*
```
(cherry picked from commit 68ec9b48592fe88765bcc3a73093d43c98b315de)
Conflicts:
routers/web/repo/view.go
templates/base/head_navbar.tmpl
templates/repo/code/recently_pushed_new_branches.tmpl
templates/repo/diff/box.tmpl
templates/repo/diff/compare.tmpl
templates/repo/diff/conversation.tmpl
templates/repo/header.tmpl
templates/repo/issue/filter_list.tmpl
templates/repo/issue/view_content/conversation.tmpl
templates/repo/issue/view_content/sidebar.tmpl
templates/repo/settings/options.tmpl
templates/repo/view_file.tmpl
templates/shared/user/blocked_users.tmpl
templates/status/500.tmpl
web_src/js/components/DashboardRepoList.vue
resolved by prefering Forgejo version and applying the
commands to all files
2024-03-30 07:17:29 +01:00
a579a0f318
[Port] gitea#30014: Various code view improvements
...
1. Restore missing styles for message close icon
2. Move `code-line-button` so that it does not go off-screen on small
viewports
3. Make `code-line-button` look and behave like other buttons
4. Make `code-line-button` work in blame
5. Make the active selection span the whole line, not just the code part
6. Tweak colors, make dark theme code bg darker, make line numbers same
color in diff and file view.
7. Move code background to parent, fixing border radius and other
problems
8. Enable code wrap in blame
9. Improve blame responsiveness
10. Remove `--color-code-sidebar-bg` in blame, now it uses same
background as code
11. Rename `--color-active-line` to `--color-highlight-bg`
12. Add `--color-highlight-bg`
13. Fix button group borders on hover and border-right on last button.
<img width="1343" alt="Screenshot 2024-03-23 at 22 34 13"
src="https://github.com/go-gitea/gitea/assets/115237/fcbb919f-5dc3-43f0-97f6-870d6f412554 ">
<img width="1334" alt="Screenshot 2024-03-23 at 22 34 26"
src="https://github.com/go-gitea/gitea/assets/115237/ca44c3b7-4328-4645-ba49-b0dc6a5ac06d ">
<img width="1338" alt="Screenshot 2024-03-23 at 22 34 57"
src="https://github.com/go-gitea/gitea/assets/115237/00eb0b5a-1ec7-4669-a94a-4602b9d1c1ac ">
<img width="1337" alt="Screenshot 2024-03-23 at 22 34 42"
src="https://github.com/go-gitea/gitea/assets/115237/752edc4a-064f-413c-9dff-c086187fcd85 ">
Fixes: https://github.com/go-gitea/gitea/issues/18074
---
Conflict resolution: Trivial.
Ref: https://codeberg.org/forgejo/forgejo/issues/2776
(cherry picked from commit db01bf6cc88a8a7b5132b9306b3af1649566b10f)
2024-03-28 16:43:14 +01:00
1684f0e5bf
Merge pull request '[PERFORMANCE] git check-attr on bare repo if supported' ( #2763 ) from oliverpool/forgejo:check_attr_bare into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2763
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-03-28 11:14:52 +00:00
3c81f7478c
[PERFORMANCE] git check-attr on bare repo if supported
2024-03-28 10:52:51 +01:00
327deee2d7
Merge pull request '[PORT] Support repo code search without setting up an indexer (gitea#29998)' ( #2813 ) from snematoda/port-git-grep into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2813
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-03-28 08:15:47 +00:00
1e7a6483b8
Support repo code search without setting up an indexer ( #29998 )
...
By using git's ability, end users (especially small instance users) do
not need to enable the indexer, they could also benefit from the code
searching feature.
Fix #29996
---------
Co-authored-by: silverwind <me@silverwind.io>
2024-03-28 05:16:51 +00:00
488a99fb56
Reverts commits releated to git-grep
...
This reverts commit
51fb6f398371a72d8a22
2024-03-28 05:09:41 +00:00
bc36f85b5f
[REFACTOR] webhook repo naming consistency
2024-03-27 22:26:55 +01:00
9c3611ec50
[REFACTOR] simplify checkHookType
2024-03-27 22:26:55 +01:00
c0dd92e9c5
[REFACTOR] webhook move edit endpoints
2024-03-27 22:26:55 +01:00
635230ca5d
[TESTS] webhook forms keep submitted data when invalid
2024-03-27 22:26:55 +01:00
1e050d01c0
[REFACTOR] merge once-called functions
2024-03-27 22:26:54 +01:00
4ab341e971
[REFACTOR] webhook gogs endpoint
2024-03-27 15:38:39 +01:00
dce754cde1
[REFACTOR] webhook packagist endpoint
2024-03-27 15:38:39 +01:00
36a1d37532
[REFACTOR] webhook wechatwork endpoint
2024-03-27 15:38:39 +01:00
6b719f08d0
[REFACTOR] webhook feishu endpoint
2024-03-27 15:38:39 +01:00
97f0ad49ff
[REFACTOR] webhook msteams endpoint
2024-03-27 15:38:39 +01:00
46b71ec709
[REFACTOR] webhook telegram endpoint
2024-03-27 15:38:39 +01:00
9dff719523
[REFACTOR] webhook dingtalk endpoint
2024-03-27 15:38:39 +01:00
c3f8e6ed60
[REFACTOR] webhook discord endpoint
2024-03-27 15:38:39 +01:00
6f00821f3d
[REFACTOR] webhook slack endpoints
2024-03-27 15:38:38 +01:00
7e0965b02c
[REFACTOR] webhook forgejo/gitea endpoints
2024-03-27 15:38:38 +01:00
8dfbbfef07
[REFACTOR] webhook matrix endpoints
2024-03-27 15:38:38 +01:00
e41e18f87e
Merge pull request '[REFACTOR] webhook.Handler interface' ( #2758 ) from oliverpool/forgejo:webhook_2_interface into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2758
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-03-27 13:45:04 +00:00
ac672fc3ff
Merge pull request '[ACTIONS] port scheduled actions from Gitea' ( #2826 ) from earl-warren/forgejo:wip-gitea-schedule into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2826
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-03-27 06:23:56 +00:00
b73117127c
Escape paths for find file correctly ( #30026 )
...
Fix #30020
(cherry picked from commit 1cdc6c3a4ea28396788b2697f9cf257df161ff9a)
2024-03-26 19:04:27 +01:00
196c8772a8
Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} ( #29995 )
...
(cherry picked from commit f8ab9dafb7a173a35e9308f8f784735b0f822439)
Conflicts:
routers/web/repo/fork.go
trivial context conflict, the file does not exist in Forgejo
2024-03-26 19:04:27 +01:00
d4ea1c2559
Fix some pending problems ( #29985 )
...
These changes are quite independent and trivial, so I don't want to open
too many PRs.
* https://github.com/go-gitea/gitea/pull/29882#discussion_r1529607091
* the `f.Close` should be called properly
* the error message could be more meaningful
(https://github.com/go-gitea/gitea/pull/29882#pullrequestreview-1942557935 )
*
https://github.com/go-gitea/gitea/pull/29859#pullrequestreview-1942324716
* the new translation strings don't take arguments
* https://github.com/go-gitea/gitea/pull/28710#discussion_r1443778807
* stale for long time
* #28140
* a form was forgotten to be changed to work with backend code
(cherry picked from commit 226231ea27d4f2b0f09fa4efb39501507613b284)
Conflicts:
templates/repo/issue/view_content/pull.tmpl
discarded because unexplained
templates/status/404.tmpl
implemented differently in Forgejo
2024-03-26 19:04:26 +01:00
8848b0ea2b
Fix bugs in rerunning jobs ( #29955 )
...
Fix #28761
Fix #27884
Fix #28093
## Changes
### Rerun all jobs
When rerun all jobs, status of the jobs with `needs` will be set to
`blocked` instead of `waiting`. Therefore, these jobs will not run until
the required jobs are completed.
### Rerun a single job
When a single job is rerun, its dependents should also be rerun, just
like GitHub does
(https://github.com/go-gitea/gitea/issues/28761#issuecomment-2008620820 ).
In this case, only the specified job will be set to `waiting`, its
dependents will be set to `blocked` to wait the job.
### Show warning if every job has `needs`
If every job in a workflow has `needs`, all jobs will be blocked and no
job can be run. So I add a warning message.
<img
src="https://github.com/go-gitea/gitea/assets/15528715/88f43511-2360-465d-be96-ee92b57ff67b "
width="480px" />
(cherry picked from commit 2f060c5834d81f0317c795fc281f9a07e03e5962)
2024-03-26 19:04:26 +01:00
e5920b4a62
Refactor StringsToInt64s ( #29967 )
...
And close #27176
(cherry picked from commit cdb4d1a8db096d60dba04728924dab85def45b19)
2024-03-26 19:04:26 +01:00
d92c2048b3
Performance improvements for pull request list page ( #29900 )
...
This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.
Partially fix #29585
---------
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 62f8174aa2fae1481c7e17a6afcb731a5b178cd0)
Conflicts:
models/activities/notification_list.go
moved to models/activities/notification.go
2024-03-26 19:04:26 +01:00
18e95af24f
Restore deleted branches when syncing ( #29898 )
...
Regression of #29493 . If a branch has been deleted, repushing it won't
restore it.
Lunny may have noticed that, but I didn't delve into the comment then
overlooked it:
https://github.com/go-gitea/gitea/pull/29493#discussion_r1509046867
The additional comments added are to explain the issue I found during
testing, which are unrelated to the fixes.
(cherry picked from commit f371f84fa3456c2a71470632b6458d81e4892a54)
2024-03-26 19:04:25 +01:00
0da787f237
Fix milestoneID filter bug in issue list ( #29897 )
...
Fix #29717
(cherry picked from commit 656d8e2267dbdbb595704d507a780533038bb7ed)
2024-03-26 19:04:25 +01:00
664052fb0b
Fix missing error check of bufio.Scanner ( #29882 )
...
maybe more
(cherry picked from commit 0e183d81fc5283f9d2047472de580e4f04a046c1)
2024-03-26 19:04:25 +01:00
fbf0b3d661
Only do counting when count_only=true for repo dashboard ( #29884 )
...
Ref: #29878
(cherry picked from commit b251e608c01392c947f84be387f956541bfea25c)
2024-03-26 19:04:25 +01:00
0d3ddec26c
Editor error message misleading due to re-used key. ( #29859 )
...
The error message:
`editor.file_changed_while_editing = The file contents have changed
since you started editing. <a target="_blank" rel="noopener noreferrer"
href="%s">Click here</a> to see them or <strong>Commit Changes
again</strong> to overwrite them.`
Is re-used in inappropriate contexts. The link in the key goes to a 404
when the key is used in a situation where the file contents have not
changed.
Added two new keys to differentiate commit id mismatch and push out of
date conditions.
(cherry picked from commit 16e360099d0a515d429538ec88cff1f3ede23fb4)
2024-03-26 19:04:25 +01:00
a2f4ab60e8
Fix missing code in the user profile ( #29865 )
...
fix #29820
deleted by
https://github.com/go-gitea/gitea/pull/29248/files#diff-2b0b591787f16325539485e648a09ab6d3177f47dc129cfe84a35ffe141dfd19L39-L62 ,
which causing malfunction of follow/unfollow and missing description in
the user profile page.
(cherry picked from commit 5ca65d33906ebbca1e502536ffef18942b541c1d)
Conflicts:
routers/web/shared/user/header.go
trivial context conflict because of user blocking code
2024-03-26 19:04:25 +01:00
a117dfd2b1
[ACTIONS] port scheduled actions from Gitea
...
Refs: https://codeberg.org/forgejo/forgejo/issues/2798
2024-03-26 16:51:56 +01:00
0f79122053
[BUG] Detect protected branch on branch rename
...
- If a branch cannot be renamed due to a protected branch rule, show
this error in the UI instead of throwing an internal server error.
- Add integration test (also simplify the existing one).
- Resolves #2751
2024-03-26 15:58:52 +01:00
cf78141bdd
Fix an actions schedule bug ( #28942 )
...
In #28691 , schedule plans will be deleted when a repo's actions unit is
disabled. But when the unit is enabled, the schedule plans won't be
created again.
This PR fixes the bug. The schedule plans will be created again when the
actions unit is re-enabled
(cherry picked from commit adc3598a75
2024-03-25 16:27:32 +01:00
3b3747ffe8
Fix schedule tasks bugs ( #28691 )
...
Fix #28157
This PR fix the possible bugs about actions schedule.
- Move `UpdateRepositoryUnit` and `SetRepoDefaultBranch` from models to
service layer
- Remove schedules plan from database and cancel waiting & running
schedules tasks in this repository when actions unit has been disabled
or global disabled.
- Remove schedules plan from database and cancel waiting & running
schedules tasks in this repository when default branch changed.
(cherry picked from commit 97292da960
2024-03-25 16:25:02 +01:00
702152bfde
[REFACTOR] webhook.Handler interface
2024-03-24 10:35:06 +01:00
5a18b74632
Merge pull request '[TESTS] fail when log.Error is called' ( #2657 ) from oliverpool/forgejo:fail_test_on_log_error into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2657
2024-03-24 07:28:31 +00:00
2d209f1130
drop log.Error in ReadRepoNotifications
2024-03-24 07:12:31 +01:00
fb6bcf1029
packages/maven: log.Warn on bad request
2024-03-24 07:12:31 +01:00
7b576d0a5d
activitypub: warn instead of error
2024-03-24 07:12:31 +01:00
e7abda6a0d
actions artifacts: warn instead of error on invalid request
2024-03-24 07:12:31 +01:00
0bfd4ca532
Merge pull request 'Allow users to hide all "Add more units..." hints' ( #2533 ) from algernon/forgejo:less-is-more into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2533
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-03-24 05:42:37 +00:00
b7c535dba8
Merge pull request '[TESTS] webhook forms creation and edition' ( #2755 ) from oliverpool/forgejo:webhook_1_tests into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2755
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-03-24 05:35:07 +00:00
crazeteam