Aravinth Manivannan
f9cbea3d6b
feat: access ActivityPub client through interfaces to facilitate mocking in unit tests ( #4853 )
...
Was facing issues while writing unit tests for federation code. Mocks weren't catching all network calls, because was being out of scope of the mocking infra. Plus, I think we can have more granular tests.
This PR puts the client behind an interface, that can be retrieved from `ctx`. Context doesn't require initialization, as it defaults to the implementation available in-tree. It may be overridden when required (like testing).
## Mechanism
1. Get client factory from `ctx` (factory contains network and crypto parameters that are needed)
2. Initialize client with sender's keys and the receiver's public key
3. Use client as before.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4853
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Aravinth Manivannan <realaravinth@batsense.net>
Co-committed-by: Aravinth Manivannan <realaravinth@batsense.net>
2024-08-07 05:45:24 +00:00
Earl Warren
1ddf44edd6
Merge pull request '[BUG] Render references to cross-repo issues with external issues' ( #4860 ) from gusted/forgejo-ref-on-external into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4860
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-07 05:42:36 +00:00
Gusted
05e163aaf3
[BUG] Render references to cross-repo issues with external issues
...
- If you have the external issue setting enabled, any reference would
have been rendered as an external issue, however this shouldn't be
happening to references that refer to issues in other repositories.
- Unit test added.
2024-08-07 03:19:26 +02:00
Gusted
3bf87d157e
Merge pull request 'Update dependency vue to v3.4.36 (forgejo)' ( #4858 ) from renovate/forgejo-patch-vue-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4858
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-07 00:48:35 +00:00
Renovate Bot
6f3a88971e
Update dependency vue to v3.4.36
2024-08-07 00:03:03 +00:00
Gusted
85f455964d
Merge pull request 'ci: add `workflow_dispatch` to renovate and mirror' ( #4846 ) from viceice/workflow-dispatch into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4846
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-06 21:39:35 +00:00
Gusted
feffdd90f0
Merge pull request 'Use FORGEJO_WORK_DIR in example systemd service' ( #4851 ) from jondo/forgejo:jondo-patch-1 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4851
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-06 21:32:01 +00:00
Gusted
192177fc88
[BUG] Ensure all filters are persistent in issue filters
...
- Ensure that all filters are set in the issue filters links, thus
becoming persistent.
- Adds integration test
- Resolves #4843
2024-08-06 17:12:10 +02:00
jondo
ba9ce4b420
Switch to FORGEJO_WORK_DIR in the systemd service configuration file ( #4850 )
...
This is for https://codeberg.org/forgejo/forgejo/issues/4850
2024-08-06 14:56:13 +00:00
Gusted
7faea490fc
Merge pull request '[UI] Do not include trailing EOL character when counting lines' ( #4835 ) from gusted/forgejo-num-lines into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4835
Reviewed-by: Caesar Schinas <caesar@caesarschinas.com>
Reviewed-by: Otto <otto@codeberg.org>
2024-08-06 12:23:24 +00:00
Michael Kriese
4fb19da661
ci: add `workflow_dispatch` to renovate and mirror
2024-08-06 13:52:36 +02:00
0ko
ecad5c9aae
Merge pull request '[UI] Add background to reactions on hover' ( #4836 ) from gusted/forgejo-reaction-bg into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4836
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
2024-08-06 09:54:28 +00:00
Earl Warren
86dadda21e
Merge pull request 'Update module github.com/go-logr/logr to v1.4.2 (forgejo)' ( #4838 ) from renovate/forgejo-github.com-go-logr-logr-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4838
Reviewed-by: thefox <thefox@noreply.codeberg.org>
2024-08-06 06:29:58 +00:00
Shiny Nematoda
06d2e90fa4
feat: highlighted code search results ( #4749 )
...
closes #4534
<details>
<summary>Screenshots</summary>
![](https://codeberg.org/attachments/0ab8a7b0-6485-46dc-a730-c016abb1f287 )
</details>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4749
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
2024-08-06 05:57:25 +00:00
Earl Warren
517637137c
Merge pull request '[gitea] week 2024-32 cherry pick (gitea/main -> forgejo)' ( #4801 ) from earl-warren/wcp/2024-32 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4801
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-06 05:47:20 +00:00
Earl Warren
fb311fcf10
Merge pull request 'Update dependency @playwright/test to v1.46.0 (forgejo)' ( #4841 ) from renovate/forgejo-playwright-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4841
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-06 05:32:09 +00:00
Gusted
5cf976739c
[UI] Do not include trailing EOL character when counting lines
...
- Adjust the counting of the number of lines of a file to match the
amount of rendered lines. This simply means that a file with the content
of `a\n` will be shown as having `1 line` rather than `2 lines`. This
matches with the amount of lines that are being rendered (the last empty
line is never rendered) and matches more with the expecation of the
user (a trailing EOL is a technical detail).
- In the case there's no EOL, the reason why it was counting
'incorrectly' was to show if there was a trailing EOL or not, but now
text is shown to tell the user this.
- Integration test added.
- Resolves Codeberg/Community#1612
2024-08-06 04:36:57 +02:00
Renovate Bot
10647bb50f
Update dependency @playwright/test to v1.46.0
2024-08-06 02:05:18 +00:00
Gusted
7fb82afa20
Merge pull request 'Update dependency postcss to v8.4.41 (forgejo)' ( #4837 ) from renovate/forgejo-postcss-packages into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4837
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-06 01:48:44 +00:00
Gusted
14850847ee
Merge pull request '[BUG] Allow 4 charachter SHA in `/src/commit`' ( #4828 ) from gusted/forgejo-short-sha into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4828
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-06 01:06:34 +00:00
Renovate Bot
4b8726e599
Update module github.com/go-logr/logr to v1.4.2
2024-08-06 00:16:56 +00:00
Renovate Bot
d122196fac
Update dependency postcss to v8.4.41
2024-08-06 00:16:18 +00:00
Gusted
cc11b3027c
[UI] Add reaction hover background color
...
- Follows 595e8abd68
- Add the reaction hover background color variable, slightly lighter
than the active background color.
2024-08-06 02:07:02 +02:00
Gusted
b967fce25d
[BUG] Allow 4 charachter SHA in `/src/commit`
...
- Adjust the `RepoRefByType` middleware to allow for commit SHAs that
are as short as 4 characters (the minium that Git requires).
- Integration test added.
- Follow up to 4d76bbeda7
- Resolves #4781
2024-08-06 01:45:41 +02:00
Earl Warren
641b0f74b6
Merge pull request 'Remove dachary from CODEOWNERS' ( #4826 ) from gusted-patch-1 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4826
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 21:08:12 +00:00
Earl Warren
ed3fe01dd3
Merge pull request '[CHORE] Remove SSH DSA tests' ( #4827 ) from gusted/forgejo-rm-dsa into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4827
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 21:03:25 +00:00
Gusted
eb8c125788
[CHORE] Remove SSH DSA tests
...
- Partially resolves #4659
- Fixes CI.
2024-08-05 20:34:19 +02:00
Gusted
4d789163bc
Remove dachary from CODEOWNERS
...
I've asked dachary personally if this okay and he agreed.
2024-08-05 18:12:11 +00:00
Earl Warren
b7a4703231
Merge pull request 'Update module github.com/google/go-github/v57 to v63 (forgejo)' ( #4824 ) from renovate/forgejo-github.com-google-go-github-v57-63.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4824
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 15:07:43 +00:00
Earl Warren
d853c8465d
Update module github.com/google/go-github/v57 to v63 (license update)
2024-08-05 16:26:06 +02:00
Earl Warren
6e98a57096
Merge pull request 'Implement an instance-wide activitypub actor' ( #4811 ) from algernon/forgejo:to-be-or-not-to-be into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4811
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 14:23:02 +00:00
Renovate Bot
eab599de41
Update module github.com/google/go-github/v57 to v63
2024-08-05 13:21:39 +00:00
Gergely Nagy
f121e87aa6
activitypub: Implement an instance-wide actor
...
An instance-wide actor is required for outgoing signed requests that are
done on behalf of the instance, rather than on behalf of other actors.
Such things include updating profile information, or fetching public
keys.
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-08-05 10:50:26 +02:00
Earl Warren
057256553b
Merge pull request 'Update module golang.org/x/oauth2 to v0.22.0 (forgejo)' ( #4816 ) from renovate/forgejo-golang.org-x-oauth2-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4816
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-08-05 07:52:39 +00:00
Earl Warren
88d5d78403
Update module golang.org/x/oauth2 to v0.22.0 (license update)
2024-08-05 09:01:07 +02:00
Renovate Bot
8e3b33dd53
Update module golang.org/x/oauth2 to v0.22.0
2024-08-05 09:01:05 +02:00
Earl Warren
98457eb67d
Merge pull request 'Update module golang.org/x/sys to v0.23.0 (forgejo)' ( #4817 ) from renovate/forgejo-golang.org-x-sys-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4817
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-08-05 06:59:14 +00:00
TheFox0x7
c738542201
Open telemetry integration ( #3972 )
...
This PR adds opentelemetry and chi wrapper to have basic instrumentation
<!--start release-notes-assistant-->
## Draft release notes
<!--URL:https://codeberg.org/forgejo/forgejo-- >
- Features
- [PR](https://codeberg.org/forgejo/forgejo/pulls/3972 ): <!--number 3972 --><!--line 0 --><!--description YWRkIHN1cHBvcnQgZm9yIGJhc2ljIHJlcXVlc3QgdHJhY2luZyB3aXRoIG9wZW50ZWxlbWV0cnk=-->add support for basic request tracing with opentelemetry<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3972
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
2024-08-05 06:04:39 +00:00
0ko
7c74def6ff
i18n(en): remove unused strings ( #4805 )
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4805
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 05:54:29 +00:00
Earl Warren
e08e47bbec
Update module golang.org/x/sys to v0.23.0 (license updates)
2024-08-05 07:45:16 +02:00
forgejo-renovate-action
3d4271e731
Merge pull request 'Update renovate to v38.18.12 (forgejo)' ( #4815 ) from renovate/forgejo-renovate into forgejo
2024-08-05 05:29:17 +00:00
Earl Warren
811d96e74a
Merge pull request 'Lock file maintenance (forgejo)' ( #4818 ) from renovate/forgejo-lock-file-maintenance into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4818
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-05 05:27:45 +00:00
Solomon Victorino
3ee5bc262f
fix(ui): handle out-of-bounds end line in code selection ( #4788 )
...
- fallback to the last line, preventing TypeError
- add E2E test
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4788
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Solomon Victorino <git@solomonvictorino.com>
Co-committed-by: Solomon Victorino <git@solomonvictorino.com>
2024-08-05 04:45:07 +00:00
Renovate Bot
a3fa6c7d8e
Lock file maintenance
2024-08-05 02:06:16 +00:00
Renovate Bot
2c95baffeb
Update module golang.org/x/sys to v0.23.0
2024-08-05 02:04:33 +00:00
Renovate Bot
00ae44129d
Update renovate to v38.18.12
2024-08-05 00:02:57 +00:00
Gergely Nagy
cd17eb0fa7
activitypub: Sign the Host header too
...
Mastodon with `AUTHORIZED_FETCH` enabled requires the `Host` header to
be signed too, add it to the default for `setting.Federation.GetHeaders`
and `setting.Federation.PostHeaders`.
For this to work, we need to sign the request later: not immediately
after `NewRequest`, but just before sending them out with `client.Do`.
Doing so also lets us use `setting.Federation.GetHeaders` (we were using
`.PostHeaders` even for GET requests before).
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-08-04 23:57:48 +02:00
Earl Warren
c031881a20
Merge pull request 'Update module github.com/meilisearch/meilisearch-go to v0.27.2 (forgejo)' ( #4799 ) from renovate/forgejo-github.com-meilisearch-meilisearch-go-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4799
Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>
2024-08-04 16:25:38 +00:00
Earl Warren
359f712b46
chore(release-notes): weekly cherry-pick week 2024-32
2024-08-04 18:24:10 +02:00
Lunny Xiao
46f9fc2bc6
Rename head branch of pull requests when renaming a branch ( #31759 )
...
Fix #31716
(cherry picked from commit 572aaebd96b43bc576fe32187be82f689e855464)
2024-08-04 18:24:10 +02:00