mirror of
1
Fork 0
forgejo/contrib
Lunny Xiao 6433ba0ec3
Move macaron to chi (#14293)
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR.

- [x] Define `context.ResponseWriter` interface with an implementation `context.Response`.
- [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before.
- [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic .
- [x] Use https://github.com/unrolled/render instead of macaron's internal render
- [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip
- [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK**
- [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha
- [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache
- [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding
- [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors
- [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation`
- [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle.
- [x] Removed macaron log service because it's not need any more. **BREAK**
- [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition.
- [x] Move Git HTTP protocol implementation to use routers directly.
- [x] Fix the problem that chi routes don't support trailing slash but macaron did.
- [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. 

Notices:
- Chi router don't support request with trailing slash
- Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI.

Co-authored-by: 6543 <6543@obermui.de>
2021-01-26 16:36:53 +01:00
..
environment-to-ini Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 2020-11-27 21:42:08 -05:00
fhs-compliant-script Add FHS-compliant-script (#6923) 2019-05-26 17:49:54 -04:00
fixtures Move fixture generation to contrib and add test (#10277) 2020-02-15 10:59:43 +02:00
ide fix quotation marks in launch.json (#13325) 2020-10-27 16:58:09 -04:00
init Make the default PID file compile-time settable (#12485) 2020-08-15 21:15:27 +01:00
launchd Synced gitignores with github repo (#1245) 2017-03-15 13:30:00 +01:00
legal [Contrib] Change License Link to Full CC0 Legalcode (PP and TOS) (#10057) 2020-06-02 21:22:17 -04:00
options/label Adding advanced label set. (#11298) 2020-05-07 07:47:34 +01:00
pr Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
supervisor Synced gitignores with github repo (#1245) 2017-03-15 13:30:00 +01:00
systemd systemd service: Add commented PATH environment option for Git prefix (#13170) 2020-10-24 17:13:59 -04:00
README Synced gitignores with github repo (#1245) 2017-03-15 13:30:00 +01:00
autoboot.sh Synced gitignores with github repo (#1245) 2017-03-15 13:30:00 +01:00
mysql.sql Synced gitignores with github repo (#1245) 2017-03-15 13:30:00 +01:00

README

All files in subdirectories are templates, do modifications based on your environment first.