mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/templates/repo/pulls
History
Markus Amshove b1d66f50fb
Disallow merge when required checked are missing (#29143) 
fixes #21892

This PR disallows merging a PR when not all commit status contexts
configured in the branch protection are met.

Previously, the PR was happy to merge when one commit status was
successful and the other contexts weren't reported.

Any feedback is welcome, first time Go :-)
I'm also not sure if the changes in the template break something else

Given the following branch protection:

![branch_protection](https://github.com/go-gitea/gitea/assets/2401875/f871b4e4-138b-435a-b496-f9ad432e3dec)

This was shown before the change:

![before](https://github.com/go-gitea/gitea/assets/2401875/60424ff0-ee09-4fa0-856e-64e6e3fb0612)

With the change, it is now shown as this:

![after](https://github.com/go-gitea/gitea/assets/2401875/4e464142-efb1-4889-8166-eb3be26c8f3d)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit a11ccc9fcd61fb25ffb1c37b87a0df4ee9efd84e)
 		2024-02-19 22:58:33 +01:00
..
commits.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
files.tmpl Make diff view full width again (#24598) 2023-05-09 05:21:03 +00:00
fork.tmpl Add support for forking single branch (#25821) 2023-09-29 09:48:39 +08:00
status.tmpl Disallow merge when required checked are missing (#29143) 2024-02-19 22:58:33 +01:00
tab_menu.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00