mirror of
1
Fork 0
forgejo/routers/web
Archer 02474498b1
Prevent automatic OAuth grants for public clients (#30790)
This commit forces the resource owner (user) to always approve OAuth 2.0
authorization requests if the client is public (e.g. native
applications).

As detailed in [RFC 6749 Section 10.2](https://www.rfc-editor.org/rfc/rfc6749.html#section-10.2),

> The authorization server SHOULD NOT process repeated authorization
requests automatically (without active resource owner interaction)
without authenticating the client or relying on other measures to ensure
that the repeated request comes from the original client and not an
impersonator.

With the implementation prior to this patch, attackers with access to
the redirect URI (e.g., the loopback interface for
`git-credential-oauth`) can get access to the user account without any
user interaction if they can redirect the user to the
`/login/oauth/authorize` endpoint somehow (e.g., with `xdg-open` on
Linux).

Fixes #25061.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 5c542ca94caa3587329167cfe9e949357ca15cf1)
(cherry picked from commit 1b088fade6)
2024-06-06 13:58:50 +02:00
..
admin Forbid removing the last admin user (#28337) (#28793) 2024-01-16 14:41:11 +00:00
auth Prevent automatic OAuth grants for public clients (#30790) 2024-06-06 13:58:50 +02:00
devtest Make "cancel" buttons have proper type in modal forms (#25618) 2023-07-03 14:04:50 +08:00
events Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
explore Only use supported sort order for "explore/users" page (#29430) (#29443) 2024-03-10 18:45:59 +07:00
feed Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
healthcheck [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2023-11-13 13:58:17 +01:00
misc Refactor CORS handler (#28587) (#28611) 2024-01-16 14:08:38 +00:00
org Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
repo Fix possible renderer security problem(#30136) (#30315) 2024-04-15 11:36:01 +02:00
shared Fix project counter in organization/individual profile (#28068) (#29361) 2024-03-06 12:20:42 +08:00
user Fix 500 when deleting account with incorrect password or unsupported login type (#29579) (#29656) 2024-03-10 18:45:59 +07:00
base.go Fix panic in storageHandler (#27446) (#27479) 2023-10-06 16:51:26 +02:00
githttp.go Refactor CORS handler (#28587) (#28611) 2024-01-16 14:08:38 +00:00
goget.go Support SSH for go get (#24664) 2023-05-12 09:44:37 +00:00
home.go [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger_json.go Start using template context function (#26254) 2023-08-08 01:22:47 +00:00
web.go Use Get but not Post to get actions artifacts (#29734) (#29737) 2024-03-21 09:25:14 +01:00
webfinger.go Add a link to OpenID Issuer URL in WebFinger response (#26000) 2023-07-20 16:02:45 +08:00