mirror of
1
Fork 0
forgejo/templates
silverwind a01387f5b1
Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384

On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.

Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.

I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)

Conflicts:
	- templates/repo/settings/options.tmpl
	  Conflict resolved by manually removing all `id` and `for`
	  attributes from elements that had `repo_name` as their id.
2024-04-22 08:09:00 +02:00
..
admin Fix admin notice view-detail (#30450) 2024-04-15 20:01:36 +02:00
api/packages/pypi Update templates/api/packages/pypi/simple.tmpl 2024-04-12 16:43:30 +00:00
base Add `[other].SHOW_FOOTER_POWERED_BY` setting to hide `Powered by` (#30253) 2024-04-07 15:40:31 +02:00
custom [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
devtest Remove fomantic input module (#30194) 2024-04-07 15:40:31 +02:00
explore [BUG] Fix tooltip for 1000+ stars/forks 2024-04-10 23:53:40 +02:00
mail Provide a way to translate data units 2024-03-30 21:10:47 +05:00
org Fix the spacing issue in the Project view (#30415) 2024-04-15 20:01:36 +02:00
package Some NuGet package enhancements 2024-04-15 20:45:14 +02:00
projects [PORT] gitea##30237: Fix and rewrite contrast color calculation, fix project-related bugs 2024-04-15 16:11:34 +02:00
repo Add form field id generation, remove duplicated ids (#30546) 2024-04-22 08:09:00 +02:00
shared Make display of EasyMDE in UI optional to template 2024-04-15 21:23:33 +05:00
status Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
swagger Merge pull request 'Do not require login_name & source_id for /admin/user/{username}' (#3278) from algernon/forgejo:leave-your-name-at-the-door into forgejo 2024-04-17 11:05:13 +00:00
user Various improvements to pages: notifications and subscriptions 2024-04-16 15:29:28 +05:00
webhook webhook: matrix access_token helper text 2024-04-16 08:59:56 +02:00
home.tmpl Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
install.tmpl Update checker setting updates 2024-03-31 10:52:24 +05:00
post-install.tmpl [BRANDING] Custom loading animation for Forgejo 2024-02-05 16:02:13 +01:00