mirror of
1
Fork 0
forgejo/routers/api/v1
Giteabot 203fe2841d
Fix `Permission` in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
activitypub Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) 2023-04-04 10:08:23 +08:00
admin Refactor rename user and rename organization (#24052) 2023-05-21 23:13:47 +08:00
misc Add API for Label templates (#24602) 2023-05-23 18:10:23 +08:00
notify Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
org Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
packages Add CRAN package registry (#22331) 2023-05-22 10:57:49 +08:00
repo Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
settings Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger API endpoint for changing/creating/deleting multiple files (#24887) 2023-05-29 17:41:35 +08:00
user Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
utils New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00
api.go Redesign Scoped Access Tokens (#24767) 2023-06-04 20:57:16 +02:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00