mirror of
1
Fork 0
forgejo/services/convert
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 21:09:51 +01:00
..
activity.go For API attachments, use API URL (#25639) 2023-07-10 09:31:19 +00:00
attachment.go Fix attachment download bug (#27486) 2023-10-10 15:33:56 +00:00
convert.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
git_commit.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
git_commit_test.go Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
issue.go Final round of `db.DefaultContext` refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_comment.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_test.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
mirror.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
notification.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
package.go Fix package webhook (#27839) 2023-10-31 04:43:38 +00:00
pull.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
pull_review.go Fix `convert.ToTeams` on empty input (#28426) 2024-01-11 22:12:08 +00:00
pull_test.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
release.go add Upload URL to release API (#26663) 2023-08-24 10:36:10 +00:00
release_test.go add Upload URL to release API (#26663) 2023-08-24 10:36:10 +00:00
repository.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
secret.go feat: implement organization secret creation API (#26566) 2023-08-22 11:20:34 +08:00
status.go refactor improve NoBetterThan (#26126) 2023-07-26 08:52:07 +00:00
user.go Fix API leaking Usermail if not logged in (#25097) 2023-07-31 01:18:38 +00:00
user_test.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
utils.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
utils_test.go Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
wiki.go Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00