mirror of
1
Fork 0
forgejo/services/actions
Giteabot 203fe2841d
Fix `Permission` in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
clear_tasks.go Refactor commit status for Actions jobs (#23786) 2023-03-29 11:27:37 -04:00
commit_status.go Handle canceled workflow as a warning instead of a fail (#24282) 2023-04-23 14:41:55 -04:00
init.go Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
job_emitter.go Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
job_emitter_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
notifier.go Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
notifier_helper.go Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00