mirror of
1
Fork 0
forgejo/modules/packages
Zettat123 6b74043b85
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled ()
Fix 

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)
(cherry picked from commit 0690cb076bf63f71988a709f62a9c04660b51a4f)

Conflicts:
	- modules/storage/azureblob.go
	  Dropped the change, as we do not support Azure blob storage.
	- modules/storage/helper.go
	  Resolved by adjusting their `discardStorage` to our
	  `DiscardStorage`
	- routers/api/actions/artifacts.go
	  routers/api/actions/artifactsv4.go
	  routers/web/repo/actions/view.go
	  routers/web/repo/download.go
	  Resolved the conflicts by manually adding the new `nil`
	  parameter to the `storage.Attachments.URL()` calls.

	  Originally conflicted due to differences in the if expression
	  above these calls.
2024-11-05 09:33:15 +01:00
..
alpine Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
arch feat: add architecture-specific removal support for arch package () 2024-09-27 08:21:22 +00:00
cargo Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
chef Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
composer Add bin to Composer Metadata () 2024-09-27 08:42:48 +02:00
conan Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
conda Support compression for Actions logs () 2024-08-13 06:51:49 +02:00
container Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
cran Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
debian Support compression for Actions logs () 2024-08-13 06:51:49 +02:00
goproxy Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
helm Replace `interface{}` with `any` () 2023-07-04 18:36:08 +00:00
maven Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
npm Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
nuget Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
pub Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
pypi Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
rpm Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
rubygems Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
swift Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
vagrant Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
content_store.go Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled () 2024-11-05 09:33:15 +01:00
hashed_buffer.go Close all hashed buffers () 2023-10-25 21:24:24 +02:00
hashed_buffer_test.go Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00
multi_hasher.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
multi_hasher_test.go Add testifylint to lint checks () 2024-07-30 19:41:10 +00:00