mirror of
1
Fork 0
forgejo/routers/api
Gergely Nagy 969d3f4410
Fix `/api/v1/{owner}/{repo}/issue_templates`
Backport of 

When issue templates were moved into services in
def4956122, the code was also refactored
and simplified. Unfortunately, that simplification broke the
`/api/v1/{owner}/{repo}/issue_templates` route, because it was
previously using a helper function that ignored invalid templates, and
after the refactor, the function it called *always* returned non-nil as
the second return value. This, in turn, results in the aforementioned
end point always returning an internal server error.

This change restores the previous behaviour of ignoring invalid files
returned by `issue.GetTemplatesFromDefaultBranch`, and adds a few test
cases to exercise the endpoint.

Other users of `GetTemplatesFromDefaultBranch` already ignore the second
return value, or handle it correctly, so no changes are necessary there.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit be8d16438a)
2024-03-07 21:50:27 +01:00
..
actions Fix uploaded artifacts should be overwritten () backport v1.21 () 2024-01-31 14:18:25 +01:00
forgejo/v1 [API] Forgejo API /api/forgejo/v1 2023-11-13 12:33:48 +01:00
packages Fix swift packages not resolving () () 2024-02-13 14:29:41 +01:00
v1 Fix `/api/v1/{owner}/{repo}/issue_templates` 2024-03-07 21:50:27 +01:00