mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/routers/api/v1/repo
History
Gergely Nagy 969d3f4410
Fix `/api/v1/{owner}/{repo}/issue_templates` 
Backport of #2292

When issue templates were moved into services in
def4956122, the code was also refactored
and simplified. Unfortunately, that simplification broke the
`/api/v1/{owner}/{repo}/issue_templates` route, because it was
previously using a helper function that ignored invalid templates, and
after the refactor, the function it called *always* returned non-nil as
the second return value. This, in turn, results in the aforementioned
end point always returning an internal server error.

This change restores the previous behaviour of ignoring invalid files
returned by `issue.GetTemplatesFromDefaultBranch`, and adds a few test
cases to exercise the endpoint.

Other users of `GetTemplatesFromDefaultBranch` already ignore the second
return value, or handle it correctly, so no changes are necessary there.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit be8d16438a)
 		2024-03-07 21:50:27 +01:00
..
action.go Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
avatar.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
blob.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
branch.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-12 15:21:33 +01:00
collaborators.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go [BRANDING] add X-Forgejo-* headers 2023-11-13 13:58:18 +01:00
fork.go Reduce usage of `db.DefaultContext` (#27073) 2023-09-14 17:09:32 +00:00
git_hook.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
hook_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
issue_attachment.go [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
issue_comment.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
issue_comment_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
issue_dependency.go Fix issue dependencies (#27736) (#28776) 2024-01-16 14:39:23 +00:00
issue_label.go [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
issue_pin.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
issue_reaction.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
issue_stopwatch.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_subscription.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_tracked_time.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
key.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
label.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
migrate.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
milestone.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
mirror.go Add `RemoteAddress` to mirrors (#26952) 2023-09-16 16:03:02 +00:00
notes.go api: GetPullRequestCommits: return file list (#27483) (#27539) 2023-10-09 14:21:35 +02:00
patch.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
pull.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
pull_review.go More `db.DefaultContext` refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
release.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
release_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
release_tags.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
repo.go Fix `/api/v1/{owner}/{repo}/issue_templates` 2024-03-07 21:50:27 +01:00
repo_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
star.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
status.go Fix `GetCommitStatuses` (#28787) (#28804) 2024-01-16 14:40:56 +00:00
subscriber.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
tag.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
teams.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
topic.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
transfer.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
tree.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
wiki.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00