mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/templates/org/settings
History
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097) 
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 		2023-04-23 17:24:19 +08:00
..
applications.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
applications_oauth2_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
delete.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
hook_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
hooks.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
labels.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2023-03-14 11:34:09 +08:00
navbar.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
options.tmpl Limit avatar upload to valid image files (#24258) 2023-04-21 17:58:59 -04:00
packages.tmpl Add Cargo package registry (#21888) 2023-02-05 18:12:31 +08:00
packages_cleanup_rules_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
packages_cleanup_rules_preview.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
runners.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
runners_edit.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
secrets.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00