mirror of
1
Fork 0
forgejo/templates/repo/settings
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097)
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-23 17:24:19 +08:00
..
webhook Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
branches.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
collaboration.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
deploy_keys.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
githook_edit.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
githooks.tmpl Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
lfs.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
lfs_file.tmpl Fix code view (diff) broken layout (#23096) 2023-04-04 19:05:07 +08:00
lfs_file_find.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
lfs_locks.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
lfs_pointers.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
nav.tmpl Add user secrets (#22191) 2023-02-01 20:53:04 +08:00
navbar.tmpl Add user secrets (#22191) 2023-02-01 20:53:04 +08:00
options.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
protected_branch.tmpl Allow both fullname and username search when `DEFAULT_SHOW_FULL_NAME` is true (#23463) 2023-03-16 11:32:25 -05:00
runner_edit.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
runners.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
secrets.tmpl Add user secrets (#22191) 2023-02-01 20:53:04 +08:00
tags.tmpl Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00