mirror of
1
Fork 0
forgejo/services
Jason Song 477a1cc40e
Improve utils of slices (#22379)
- Move the file `compare.go` and `slice.go` to `slice.go`.
- Fix `ExistsInSlice`, it's buggy
  - It uses `sort.Search`, so it assumes that the input slice is sorted.
- It passes `func(i int) bool { return slice[i] == target })` to
`sort.Search`, that's incorrect, check the doc of `sort.Search`.
- Conbine `IsInt64InSlice(int64, []int64)` and `ExistsInSlice(string,
[]string)` to `SliceContains[T]([]T, T)`.
- Conbine `IsSliceInt64Eq([]int64, []int64)` and `IsEqualSlice([]string,
[]string)` to `SliceSortedEqual[T]([]T, T)`.
- Add `SliceEqual[T]([]T, T)` as a distinction from
`SliceSortedEqual[T]([]T, T)`.
- Redesign `RemoveIDFromList([]int64, int64) ([]int64, bool)` to
`SliceRemoveAll[T]([]T, T) []T`.
- Add `SliceContainsFunc[T]([]T, func(T) bool)` and
`SliceRemoveAllFunc[T]([]T, func(T) bool)` for general use.
- Add comments to explain why not `golang.org/x/exp/slices`.
- Add unit tests.
2023-01-11 13:31:16 +08:00
..
agit Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
asymkey Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment Add API management for issue/pull and comment attachments (#21783) 2022-12-09 14:35:56 +08:00
auth Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
automerge refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
context Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
convert Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
cron Add doctor command for full GC of LFS (#21978) 2022-12-15 20:44:16 +00:00
externalaccount Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
forms Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
gitdiff Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
lfs Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
mailer refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
markup Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrations Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
mirror Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
packages refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
pull Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
release Add API management for issue/pull and comment attachments (#21783) 2022-12-09 14:35:56 +08:00
repository Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
task Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user Unify hashing for avatar (#22289) 2023-01-02 22:46:39 +01:00
webhook fix: omit avatar_url in discord payload when empty (#22393) 2023-01-10 14:01:52 -05:00
wiki Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00