mirror of
1
Fork 0
forgejo/modules
zeripath 858c35b731
Ensure BlameReaders close at end of request (#12102)
#11716 reports multiple git blame processes hanging around
this was thought to be due to timeouts, however on closer look this
appears to be due to the Close() function of the BlameReader hanging
with a blocked stdout pipe.

This PR fixes this Close function to:

* Cancel the context of the cmd
* Close the StdoutReader - ensuring that the output pipe is closed

Further it makes the context of the `git blame` command a child of the
request context - ensuring that even if Close() is not called, on
cancellation of the Request the blame is command will also be cancelled.

Fixes #11716
Closes #11727

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-07-01 14:01:17 +01:00
..
analyze Exclude generated files from language statistics (#11653) 2020-05-29 09:20:01 +03:00
auth Use google/uuid to instead satori/go.uuid (#11943) 2020-06-18 17:18:44 +08:00
avatar Improve handling of non-square avatars (#7025) 2019-05-25 14:46:14 +03:00
base Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
cache make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
charset Fix chardet test and add ordering option (#11621) 2020-06-02 19:20:19 -03:00
context Fix typo (#12013) 2020-06-22 11:21:11 -04:00
convert Honor DEFAULT_PAGING_NUM for API (#11805) 2020-06-08 22:46:51 -04:00
cron Refactor Cron and merge dashboard tasks (#10745) 2020-05-16 19:31:38 -04:00
emoji Update emoji dataset with skin tone variants (#11678) 2020-06-02 02:22:40 -04:00
eventsource Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
generate Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
git Ensure BlameReaders close at end of request (#12102) 2020-07-01 14:01:17 +01:00
gitgraph Move git graph from models to modules/graph (#9027) 2019-11-16 08:47:57 +08:00
graceful Handle panics that percolate up to the graceful module (#11291) 2020-05-14 20:06:00 -04:00
highlight Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
httplib Add golangci (#6418) 2019-06-12 15:41:28 -04:00
indexer Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
lfs Support Range header end in lfs (#11314) 2020-05-11 11:37:59 +03:00
log modules/log: remove noop written variables (#10182) 2020-02-07 21:35:30 +01:00
markup Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Use google/uuid to instead satori/go.uuid (#11943) 2020-06-18 17:18:44 +08:00
notification Add push commits history comment on PR time-line (#11167) 2020-05-20 09:47:24 -03:00
options Rename scripts to build and add revive command as a new build tool command (#10942) 2020-04-03 22:29:12 +03:00
password Add password requirement info on error (#9074) 2019-11-19 22:44:58 +00:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Upgrade golangci-lint to 1.24.0 (#10894) 2020-03-30 21:52:45 +03:00
process Only write to global gitconfig if necessary (#11876) 2020-06-13 17:47:31 -04:00
public Move fomantic and jQuery to main webpack bundle (#11997) 2020-06-27 22:59:56 -04:00
queue Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
recaptcha fixed reCAPTCHA URL (#9083) 2019-11-22 08:03:45 +00:00
references Accept punctuation after simple+cross repository issue references (#10091) 2020-02-01 18:01:30 +00:00
repofiles Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
repository Global default branch setting (#11918) 2020-06-17 16:53:55 -04:00
secret Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
session Prevent (caught) panic on login (#11590) 2020-05-23 20:59:04 -03:00
setting Global default branch setting (#11918) 2020-06-17 16:53:55 -04:00
ssh log.Fatal on failure to listen to SSH port (#10795) 2020-03-23 07:59:38 +00:00
structs API: Move AllowedReactions endpoint into GetGenneralUI endpoint + creat new swagger section settings (#11854) 2020-06-22 14:21:31 -04:00
sync Fix missing unlock in uniquequeue (#9790) 2020-01-15 23:58:33 +02:00
task Move create/fork repository from models to modules/repository (#9489) 2020-01-12 20:11:17 +08:00
templates [UI] Sortable Tables Header By Click (#7980) 2020-06-24 23:23:05 +01:00
test Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
timeutil Fix timezone on issue deadline (#11697) 2020-06-05 18:51:10 -04:00
upload Fix upload file type check (#7890) 2019-08-17 13:10:17 +03:00
user Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
util Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
validation [API] Get a single commit via Ref (#10915) 2020-04-07 22:54:46 -04:00
webhook Fix comments webhook panic (#12046) 2020-06-24 23:39:43 -04:00