mirror of
1
Fork 0
forgejo/tests
Danko Aleksejevs 36b6444f34 Remove tab key handling in markdown editor, add toolbar buttons instead, re #4072 #4142 (#4263)
We haven't decided much (to my knowledge), and I've been using the main branch in production (as one does) and found out even I myself rely on Tab sometimes working to move focus and have been caught off guard by it indenting lines instead.

So this removes Tab handling and instead adds two new buttons to the toolbar. The indentation logic is unchanged (other than now focusing the textarea during button handling, to ensure execCommand works, and thus undo history is preserved).

I'm not sure which terminology to use in tooltips. Could also add keyboard shortcuts for the whole toolbar eventually, but as is this is hopefully an better solution to the problems I previously created than un-merging the whole thing :)

<img width="414" alt="Screenshot with two new buttons" src="/attachments/b7af3aa4-a195-48d1-be0a-1559f25dce8e">

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4263
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Danko Aleksejevs <danko@very.lv>
Co-committed-by: Danko Aleksejevs <danko@very.lv>
2024-06-30 13:03:32 +00:00
..
e2e Remove tab key handling in markdown editor, add toolbar buttons instead, re #4072 #4142 (#4263) 2024-06-30 13:03:32 +00:00
fuzz Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
gitea-lfs-meta Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
gitea-repositories-meta Add support for workflow_dispatch (#3334) 2024-06-28 05:17:11 +00:00
integration Fixes git references wrongly transmitted to the action run 2024-06-30 06:17:40 +02:00
testdata/data/attachments/a/0 Allow get release download files and lfs files with oauth2 token format (#26430) 2023-10-01 10:41:52 +00:00
mysql.ini.tmpl Update instance title in tests 2024-06-08 23:33:55 +05:00
pgsql.ini.tmpl Update instance title in tests 2024-06-08 23:33:55 +05:00
sqlite.ini.tmpl Update instance title in tests 2024-06-08 23:33:55 +05:00
test_utils.go fix(tests): 30s to cancel processes to avoid false negatives 2024-04-18 18:47:49 +02:00