mirror of
1
Fork 0
forgejo/templates/repo/issue/view_content
silverwind e24f651c86
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
2023-06-14 18:17:58 +00:00
..
add_reaction.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
attachments.tmpl Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00
comments.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
comments_delete_time.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
context_menu.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
pull.tmpl Use flex to align SVG and text (#25163) 2023-06-14 16:40:15 +00:00
pull_merge_instruction.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
reactions.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
reference_issue_dialog.tmpl Group template helper functions, remove `Printf`, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
sidebar.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
update_branch_by_merge.tmpl Use flex to align SVG and text (#25163) 2023-06-14 16:40:15 +00:00