mirror of
1
Fork 0
forgejo/routers/web
oliverpool 8030614386
fix: release page for empty or non-existing target (#24470)
Fixes #24145

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release.
This is particularly useful if the target branch was deleted in the
meantime (or is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.
2023-05-10 11:43:55 +08:00
..
admin Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
auth Split "modules/context.go" to separate files (#24569) 2023-05-08 17:36:54 +08:00
devtest Remove untranslatable `on_date` key (#24106) 2023-04-15 13:01:54 +02:00
events Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
explore Sort users and orgs on explore by recency by default (#24279) 2023-05-06 22:04:55 +08:00
feed Pass 'not' to commit count (#24473) 2023-05-08 07:10:53 +00:00
healthcheck Refactor `setting.Database.UseXXX` to methods (#23354) 2023-03-07 18:51:06 +08:00
misc Refactor "route" related code, fix Safari cookie bug (#24330) 2023-04-27 02:06:45 -04:00
org Fix close org projects (#24588) 2023-05-08 12:19:27 +00:00
repo fix: release page for empty or non-existing target (#24470) 2023-05-10 11:43:55 +08:00
shared Add Gitea Profile Readmes (#23260) 2023-05-09 05:57:24 +00:00
user Add Gitea Profile Readmes (#23260) 2023-05-09 05:57:24 +00:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
base.go Improve template system and panic recovery (#24461) 2023-05-04 14:36:34 +08:00
goget.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
home.go Refactor cookie (#24107) 2023-04-13 15:45:33 -04:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger_json.go Group template helper functions, remove `Printf`, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
web.go Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
webfinger.go Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) 2023-04-04 10:08:23 +08:00