mirror of
1
Fork 0
forgejo/routers/api/v1/org
Giteabot 203fe2841d
Fix `Permission` in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
hook.go Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
label.go Add loading yaml label template files (#22976) 2023-03-02 01:44:23 +02:00
member.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
org.go Add activity feeds API (#23494) 2023-04-04 21:35:31 +08:00
team.go Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00