mirror of
1
Fork 0
forgejo/services/gitdiff
Rowan Bohde befafe9a05
improve performance of diffs (#32393)
This has two major changes that significantly reduce the amount of work
done for large diffs:

* Kill a running git process when reaching the maximum number of files
in a diff, preventing it from processing the entire diff.
* When loading a diff with the URL param `file-only=true`, skip loading
stats. This speeds up loading both hidden files of a diff and sections
of a diff when clicking the "Show More" button.

A couple of minor things from profiling are also included:

* Reuse existing repo in `PrepareViewPullInfo` if head and base are the
same.

The performance impact is going to depend heavily on the individual diff
and the hardware it runs on, but when testing locally on a diff changing
100k+ lines over hundreds of files, I'm seeing a roughly 75% reduction
in time to load the result of "Show More"

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 7dcccc3bb19655a6f83dd495ffc332708d0c8678)
2024-11-05 09:39:21 +01:00
..
testdata/academic-module rm .sample hooks which aren't used (#19101) 2022-03-16 10:33:07 +00:00
csv.go Use Go 1.21 and update dependencies (#26878) 2023-09-03 10:34:57 +00:00
csv_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
gitdiff.go improve performance of diffs (#32393) 2024-11-05 09:39:21 +01:00
gitdiff_test.go Fix linting issues 2024-08-18 16:25:13 +02:00
highlightdiff.go feat: Improve diff being generated 2024-08-26 13:58:17 +02:00
highlightdiff_test.go feat: highlighted code search results (#4749) 2024-08-06 05:57:25 +00:00
main_test.go tests: improve actvititypub integration test code 2024-11-01 22:39:49 +01:00