mirror of
1
Fork 0
forgejo/web_src/less
wxiaoguang affdd40296
Make issue title edit buttons focusable and fix incorrect ajax requests (#22807)
Replace #19922 , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546

Close #19769

Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better

The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.

This is also an example for future developers to understand how to make
buttons work properly.

### Before


![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png)

### After

* Add a slight margin-left.
* The `Cancel` button is focused.


![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-02-09 12:11:16 -05:00
..
chroma Improve arc-green code theme (#21039) 2022-09-03 23:24:18 +08:00
code Fix and restyle menu on code line (#15913) 2021-05-18 23:16:02 -04:00
codemirror Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
console Add support for rendering terminal output with colors (#19497) 2022-06-09 00:46:39 +03:00
features Fixed Project view .board-column height for tall screens. (#22108) 2022-12-14 21:14:50 +00:00
markup Load asciicast css async (#22502) 2023-01-18 12:19:38 -06:00
modules Use separate class for tippy targets (#20742) 2022-08-10 22:47:28 +08:00
shared Timeline and color tweaks (#21799) 2022-11-19 12:02:30 +08:00
standalone Update JS dependencies, fix lint (#18389) 2022-02-01 13:21:08 -05:00
themes Release and Tag List tweaks (#21712) 2022-12-06 21:15:46 +08:00
_actions.less Implement actions (#21937) 2023-01-31 09:45:19 +08:00
_admin.less Webhook list enhancements (#21893) 2022-11-22 07:10:42 +08:00
_base.less Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
_dashboard.less Fix margin and alignment in dashboard repolist (#22120) 2022-12-17 09:58:57 +08:00
_editor.less Extract CodeMirror styles (#17960) 2021-12-20 20:07:49 +00:00
_explore.less improve explore relevancy note (#22421) 2023-01-12 19:10:12 -06:00
_font_i18n.less Prefer "Hiragino Kaku Gothic ProN" in system-ui-ja (#17954) 2021-12-13 00:04:18 +01:00
_form.less Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
_home.less fix media query edge case (#13546) 2020-11-17 00:33:19 -05:00
_install.less Move all remaining colors into CSS variables (#21903) 2022-11-23 08:22:27 +08:00
_organization.less Add team member invite by email (#20307) 2022-10-19 14:40:28 +02:00
_package.less Fix empty container layer history and UI (#21251) 2022-09-27 15:03:24 +02:00
_repository.less Implement actions (#21937) 2023-01-31 09:45:19 +08:00
_review.less Improve code comment review on mobile (#21461) 2022-10-25 19:11:49 +08:00
_runner.less Implement actions (#21937) 2023-01-31 09:45:19 +08:00
_svg.less Update JS dependencies, fix lint (#18389) 2022-02-01 13:21:08 -05:00
_tribute.less CSS color enhancements (#21534) 2022-10-23 12:05:20 +08:00
_user.less Add badge capabilities to users (#20607) 2022-08-18 02:25:25 +03:00
animations.less Improvements for Content Copy (#21842) 2022-11-21 17:59:42 +08:00
helpers.less Improve notification and stopwatch styles (#22169) 2023-02-09 13:42:18 +08:00
index.less Implement actions (#21937) 2023-01-31 09:45:19 +08:00
variables.less fix media query edge case (#13546) 2020-11-17 00:33:19 -05:00