mirror of
1
Fork 0
forgejo/modules/log
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
buffer.go migrations: add test for importing pull requests in gitea uploader (#18752) 2022-02-25 17:20:50 +08:00
buffer_test.go migrations: add test for importing pull requests in gitea uploader (#18752) 2022-02-25 17:20:50 +08:00
colors.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
colors_router.go Refactor Router Logger (#17308) 2022-01-20 19:41:25 +08:00
conn.go migrations: add test for importing pull requests in gitea uploader (#18752) 2022-02-25 17:20:50 +08:00
conn_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
console.go migrations: add test for importing pull requests in gitea uploader (#18752) 2022-02-25 17:20:50 +08:00
console_other.go Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (#19581) 2022-05-03 18:03:34 +02:00
console_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
console_windows.go Fix windows build error (#14263) 2021-01-06 09:38:00 +08:00
errors.go Better logging (#6038) (#6095) 2019-04-02 08:48:31 +01:00
event.go Empty log queue on flush and close (#19994) 2022-06-18 10:33:13 +08:00
file.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
file_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
flags.go Log: Ensure FLAGS=none is -1 (#9287) 2019-12-07 23:36:47 -05:00
groutinelabel.go Add auto logging of goroutine pid label (#19212) 2022-03-26 20:04:36 +00:00
groutinelabel_test.go Add auto logging of goroutine pid label (#19212) 2022-03-26 20:04:36 +00:00
level.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
level_test.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
log.go Refactor Router Logger (#17308) 2022-01-20 19:41:25 +08:00
log_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
logger.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
multichannel.go Disable doctor logging on panic (#20847) 2022-08-18 21:27:27 -04:00
provider.go migrations: add test for importing pull requests in gitea uploader (#18752) 2022-02-25 17:20:50 +08:00
smtp.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
smtp_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
stack.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
writer.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
writer_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00