mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/models
History
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043) 
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 		2022-09-04 16:14:53 +01:00
..
activities Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
admin Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
appstate Sync gitea app path for git hooks and authorized keys when starting (#17335) 2021-10-21 17:22:43 +08:00
asymkey Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) 2022-08-22 14:32:28 +01:00
auth Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
avatars format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
db test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
fixtures Fix SQL Query for `SearchTeam` (#20844) 2022-08-21 17:24:05 +01:00
foreignreference Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
git Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
issues Fix missed sort bug (#20996) 2022-08-31 14:15:12 -04:00
migrations Add another index for Action table on postgres (#21033) 2022-09-03 17:27:59 +01:00
organization Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
packages Delete unreferenced packages when deleting a package version (#20977) 2022-09-03 17:01:00 +01:00
perm Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
project Add option to purge users (#18064) 2022-07-14 08:22:09 +01:00
pull Delete related PullAutoMerge and ReviewState on User/Repo Deletion (#19649) 2022-05-08 15:46:34 +02:00
repo fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2022-08-29 11:45:20 +02:00
unit Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
unittest Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
user Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
webhook Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
error.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
fixture_generation.go Move access and repo permission to models/perm/access (#19350) 2022-05-11 12:09:36 +02:00
fixture_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
main_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
migrate.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
migrate_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org_team.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org_team_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
repo.go fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2022-08-29 11:45:20 +02:00
repo_collaboration.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_collaboration_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_test.go Move tests as seperate sub packages to reduce duplicated file names (#19951) 2022-06-15 09:02:00 +02:00
repo_transfer.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_transfer_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
user.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00