mirror of
1
Fork 0
forgejo/routers/api/v1
Giteabot 4dccac3dbf
Fix api error message if fork exists (#24487) (#24493)
Backport #24487 by @fnetX

On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

---------

Co-authored-by: Otto Richter (fnetX) <git@fralix.ovh>
2023-05-03 08:15:56 -04:00
..
activitypub Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) (#23905) 2023-04-03 22:41:57 -05:00
admin Fix typo in API route (#24310) (#24332) 2023-04-25 10:57:33 -04:00
misc Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
notify Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
org Add loading yaml label template files (#22976) (#23232) 2023-03-01 21:57:34 -05:00
packages Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
repo Fix api error message if fork exists (#24487) (#24493) 2023-05-03 08:15:56 -04:00
settings Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user Add scopes to API to create token and display them (#22989) 2023-02-20 15:28:44 -06:00
utils Support system hook API (#14537) 2023-01-28 19:12:10 +01:00
api.go Fix access token issue on some public endpoints (#24194) (#24259) 2023-04-21 14:59:17 -04:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00