mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/routers/web/repo
History
Jason Song d5fec46de7
Avoid returning without written ctx when posting PR (#31843) 
Fix #31625.

If `pull_service.NewPullRequest` return an error which misses each `if`
check, `CompareAndPullRequestPost` will return immediately, since it
doesn't write the HTTP response, a 200 response with empty body will be
sent to clients.

```go
	if err := pull_service.NewPullRequest(ctx, repo, pullIssue, labelIDs, attachments, pullRequest, assigneeIDs); err != nil {
		if repo_model.IsErrUserDoesNotHaveAccessToRepo(err) {
			ctx.Error(http.StatusBadRequest, "UserDoesNotHaveAccessToRepo", err.Error())
		} else if git.IsErrPushRejected(err) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, user_model.ErrBlockedUser) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, issues_model.ErrMustCollaborator) {
			// ...
			ctx.JSONError(flashError)
		}
		return
	}
```

Not sure what kind of error can cause it to happen, so this PR just
expose it. And we can fix it when users report that creating PRs failed
with error responses.

It's all my guess since I cannot reproduce the problem, but even if it's
not related, the code here needs to be improved.

(cherry picked from commit acd7053e9d4968e8b9812ab379be9027ac8e7771)

Conflicts:
	routers/web/repo/pull.go
  trivial context conflict
(cherry picked from commit 385718dd78)
 		2024-08-21 13:03:36 +02:00
..
actions Fixes an visual bug where the info box to dispatch a workflow is shown even for users that lack permissions to actualy run the workflow. (#4305) 2024-07-06 05:36:21 +00:00
badges Enable `unparam` linter (#31277) 2024-06-16 13:42:58 +02:00
flags Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
setting Show lock owner instead of repo owner on LFS setting page (#31788) 2024-08-21 10:57:57 +00:00
activity.go Show repo activities even if only code unit active or git repo is empty but issue is active (#3455) 2024-04-28 13:47:52 +00:00
attachment.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
blame.go Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
branch.go Use repo object format name instead of detecting from git repository (#29702) 2024-03-20 08:46:28 +01:00
cherry_pick.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
code_frequency.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
commit.go [BUG] Fix panic on too high page number 2024-07-21 06:00:22 +00:00
compare.go Refactor sha1 and time-limited code (#31023) 2024-05-26 18:43:30 +02:00
contributors.go Fix Activity Page Contributors dropdown (#31264) 2024-06-18 20:05:23 +02:00
download.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
editor.go Add missed return after `ctx.ServerError` (#31130) 2024-06-02 16:26:54 +02:00
editor_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
find.go Escape paths for find file correctly (#30026) 2024-03-26 19:04:27 +01:00
githttp.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
helper.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
issue.go fix(ui): allow unreacting from comment popover 2024-08-10 09:42:40 +00:00
issue_content_history.go Remove unnecessary inline style for tab-size (#31224) 2024-06-09 11:13:39 +02:00
issue_dependency.go Use PostFormValue instead of PostForm.Get 2024-05-02 10:51:07 +02:00
issue_label.go [GITEA] Apply changes to archived labels 2024-04-01 17:46:02 +05:00
issue_label_test.go enable linter testifylint on v8 (#4573) 2024-07-30 19:41:27 +00:00
issue_lock.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_pin.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_watch.go Fix Issue watching / unwatching on the web ui 2024-05-01 11:04:54 +02:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
migrate.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
packages.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
patch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
projects.go Rename project board -> column to make the UI less confusing (#30170) 2024-06-02 09:42:39 +02:00
projects_test.go Rename project board -> column to make the UI less confusing (#30170) 2024-06-02 09:42:39 +02:00
pull.go Avoid returning without written ctx when posting PR (#31843) 2024-08-21 13:03:36 +02:00
pull_review.go Revert "Prevent allow/reject reviews on merged/closed PRs" 2024-08-15 10:47:38 +01:00
pull_review_test.go enable linter testifylint on v8 (#4573) 2024-07-30 19:41:27 +00:00
recent_commits.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
release.go [FEAT]Add Option to hide Release Archive links (#3139) 2024-04-24 15:15:55 +00:00
release_test.go enable linter testifylint on v8 (#4573) 2024-07-30 19:41:27 +00:00
render.go Refactor render (#30136) 2024-03-30 07:17:31 +01:00
repo.go Rename repo_model.SearchOrderByMap to repo_model.OrderByMap (#31359) 2024-06-16 13:42:59 +02:00
search.go [FEAT] support searching non default branches/tags when using git-grep (#3654) 2024-05-14 15:41:03 +00:00
topic.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
treelist.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
view.go [UI] Adjust trailing EOL behavior for empty file 2024-08-20 13:42:33 +00:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go feat: wiki search using git-grep 2024-05-20 13:48:50 +00:00
wiki_test.go enable linter testifylint on v8 (#4573) 2024-07-30 19:41:27 +00:00