mirror of
1
Fork 0
forgejo/routers/web/repo
qwerty287 9d943bf374
Add missing `X-Total-Count` and fix some related bugs (#17968)
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
activity.go Move unit into models/unit/ (#17576) 2021-11-09 20:57:58 +01:00
attachment.go Move attachment into models/repo/ (#17650) 2021-11-19 21:39:57 +08:00
blame.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
branch.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
commit.go Add missing `X-Total-Count` and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
compare.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
download.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
editor.go Clean legacy SimpleMDE code (#17926) 2021-12-10 10:51:27 +08:00
editor_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
http.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
http_test.go Fix http path bug (#16117) 2021-06-09 14:53:12 +02:00
issue.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
issue_content_history.go Move unit into models/unit/ (#17576) 2021-11-09 20:57:58 +01:00
issue_dependency.go Rename context.Query to context.Form (#16562) 2021-07-29 03:42:15 +02:00
issue_label.go Use a standalone struct name for Organization (#17632) 2021-11-19 19:41:40 +08:00
issue_label_test.go Decouple unit test, remove intermediate `unittestbridge` package (#17662) 2021-11-16 16:53:21 +08:00
issue_lock.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
issue_stopwatch.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
issue_test.go A better go code formatter, and now `make fmt` can run in Windows (#17684) 2021-11-17 20:34:35 +08:00
issue_timetrack.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
issue_watch.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
lfs.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
main_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
middlewares.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
migrate.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
milestone.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
projects.go Support sorting for project board issuses (#17152) 2021-12-08 14:57:18 +08:00
projects_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
pull.go Add missing `X-Total-Count` and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
pull_review.go Rename ctx.Form() to ctx.FormString() and move code into own file (#16571) 2021-08-11 02:31:13 +02:00
release.go Clean legacy SimpleMDE code (#17926) 2021-12-10 10:51:27 +08:00
release_test.go Decouple unit test, remove intermediate `unittestbridge` package (#17662) 2021-11-16 16:53:21 +08:00
repo.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
search.go Related refactors to ctx.FormX functions (#16567) 2021-08-11 18:08:52 +03:00
setting.go Return nicer error for ForcePrivate (#17971) 2021-12-14 00:08:09 -05:00
setting_protected_branch.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
settings_test.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
tag.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
topic.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
view.go Add missing `X-Total-Count` and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
webhook.go Move accessmode into models/perm (#17828) 2021-11-28 12:58:28 +01:00
wiki.go Clean legacy SimpleMDE code (#17926) 2021-12-10 10:51:27 +08:00
wiki_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00