mirror of
1
Fork 0
forgejo/routers/api/v1
Anton Khimich 5a18712dd7
Fix PATCH /repos/{owner}/{repo} panic (#14637)
* Fix a runtime error when modifying a repository through API call

Using the `PATCH /repos/{owner}/{repo}` endpoint and attempting to
modify `default_branch` on an empty repository will cause a
panic. This commit adds a check for a nil pointer before attempting
to dereference it.

* Apply suggestions from code review

* Apply suggestions from code review

* Ensure that the git repository is loaded

If you change the default branch for a repository you must change it in
git too. Therefore you must open the repository before changing the
default branch.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Allow empty repos to have their default branches changed

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Anton Khimich <anton.khimicha@mail.utoronto.ca>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Andrew Thornton <art27@cantab.net>
2021-02-11 20:53:41 +01:00
..
admin Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
misc Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
notify move notification APIFormat (#13783) 2020-12-02 09:24:35 +00:00
org [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo Fix PATCH /repos/{owner}/{repo} panic (#14637) 2021-02-11 20:53:41 +01:00
settings Added option to disable migrations (#13114) 2020-12-21 15:39:41 +01:00
swagger Add dismiss review feature (#12674) 2021-02-11 18:32:25 +01:00
user Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
utils [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
api.go Added option to disable webhooks (#13176) 2021-02-11 12:34:34 -05:00