mirror of
1
Fork 0
forgejo/modules
Earl Warren a0c26f6870
[GITEA] S3: log human readable error on connection failure
Should BucketExists (HeadBucket) fail because of an error related to
the connection rather than the existence of the bucket, no information
is available and the admin is left guessing.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html

> This action is useful to determine if a bucket exists and you have
> permission to access it. The action returns a 200 OK if the bucket
> exists and you have permission to access it.
>
> If the bucket does not exist or you do not have permission to access
> it, the HEAD request returns a generic 400 Bad Request, 403
> Forbidden or 404 Not Found code. A message body is not included, so
> you cannot determine the exception beyond these error codes.

GetBucketVersioning is used instead and exclusively dedicated to
asserting if using the connection does not return a BadRequest.
If it does the NewMinioStorage logs an error and returns. Otherwise
it keeps going knowing that BucketExists is not going to fail for
reasons unrelated to the existence of the bucket and the permissions
to access it.

(cherry picked from commit de59924605)
2023-09-11 18:09:23 +02:00
..
actions [CI] Search .forgejo/workflows first 2023-09-11 15:37:29 +02:00
activitypub move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
analyze
assetfs Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804) 2023-08-30 06:55:25 +00:00
auth [SECURITY] default to pbkdf2 with 320,000 iterations 2023-09-11 16:03:11 +02:00
avatar
base
cache
charset
container Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
context Fix the display of org level badges (#26504) 2023-09-06 14:38:14 +08:00
contexttest Avoid double-unescaping of form value (#26853) 2023-09-01 12:01:36 +00:00
csv
doctor Add fix incorrect can_create_org_repo for org owner team (#26683) 2023-08-29 01:11:23 +00:00
emoji
eventsource
generate
git Clarify the git command Stdin hanging problem (#26967) 2023-09-08 13:20:38 +00:00
gitgraph
graceful
hcaptcha
highlight
hostmatcher
html
httpcache
httplib
indexer [CI] disable meilisearch/elasticsearch test, no server yet in CI 2023-09-11 15:37:29 +02:00
issue/template
json
label
lfs
log Reduce some allocations in type conversion (#26772) 2023-08-29 00:43:16 +08:00
markup [GITEA] Fix media description render for orgmode 2023-09-11 18:09:23 +02:00
mcaptcha
metrics
migration
nosql
options
packages Use docs.gitea.com instead of docs.gitea.io (#26739) 2023-08-27 11:59:12 +00:00
paginator
pprof
private [CLI] implement forgejo-cli 2023-09-11 15:37:29 +02:00
process
proxy
proxyprotocol
public
queue [CI] disable redis test, no redis server yet in CI 2023-09-11 15:37:29 +02:00
recaptcha
references
regexplru
repository Fix context cache bug & enable context cache for dashabord commits' authors (#26991) 2023-09-11 10:14:01 +00:00
secret
session
setting [GITEA] Add slow SQL query warning 2023-09-11 18:09:23 +02:00
sitemap
ssh restrict certificate type for builtin SSH server (#26789) 2023-09-01 13:45:22 +00:00
storage [GITEA] S3: log human readable error on connection failure 2023-09-11 18:09:23 +02:00
structs [FEAT] allow setting the update date on issues and comments 2023-09-11 16:41:14 +02:00
svg
sync
system
templates Replace `util.SliceXxx` with `slices.Xxx` (#26958) 2023-09-07 09:37:47 +00:00
test Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
testlogger
timeutil
translation
turnstile
typesniffer
updatechecker Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
upload
uri
user
util Replace `util.SliceXxx` with `slices.Xxx` (#26958) 2023-09-07 09:37:47 +00:00
validation [GITEA] add option for banning dots in usernames 2023-09-11 18:09:23 +02:00
web [GITEA] add option for banning dots in usernames 2023-09-11 18:09:23 +02:00
webhook