mirror of
1
Fork 0
forgejo/models/fixtures
oliverpool 937b8e8184
fix: release page for empty or non-existing target (#24659)
Backport #24470

Fixes #24145

---

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.

_contributed in the context of @forgejo_

(cherry picked from commit cb7ba8969d)
2023-05-16 07:42:22 +02:00
..
access.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
access_token.yml
action.yml Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) (#23878) 2023-04-07 18:10:17 +08:00
attachment.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
collaboration.yml
comment.yml
commit_status.yml
commit_status_index.yml Fix commit status index problem (#17061) 2021-09-23 18:50:06 +08:00
deleted_branch.yml
deploy_key.yml
email_address.yml Always store primary email address into email_address table and also the state (#15956) 2021-06-08 11:52:51 +08:00
external_login_user.yml add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
follow.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
gpg_key.yml
gpg_key_import.yml
hook_task.yml Decouple HookTask from Repository (#17940) 2022-10-21 18:21:56 +02:00
issue.yml Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
issue_assignees.yml Fix issue overview for teams (#19652) 2022-05-16 17:49:17 +08:00
issue_index.yml Fix issue overview for teams (#19652) 2022-05-16 17:49:17 +08:00
issue_label.yml
issue_user.yml [API] ListIssues add more filters (#16174) 2021-06-16 18:33:37 -04:00
issue_watch.yml
label.yml Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
lfs_meta_object.yml Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
login_source.yml
milestone.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
notice.yml
notification.yml
oauth2_application.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_authorization_code.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_grant.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
org_user.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
project.yml Support org/user level projects (#22235) 2023-01-20 19:42:33 +08:00
project_board.yml Support org/user level projects (#22235) 2023-01-20 19:42:33 +08:00
project_issue.yml Kanban board (#8346) 2020-08-16 23:07:38 -04:00
protected_branch.yml
public_key.yml
pull_request.yml Add API endpoint to get changed files of a PR (#21177) 2022-09-29 04:27:20 +02:00
reaction.yml
release.yml fix: release page for empty or non-existing target (#24659) 2023-05-16 07:42:22 +02:00
renamed_branch.yml Add a simple way to rename branch like gh (#15870) 2021-10-08 19:03:04 +02:00
repo_archiver.yml Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
repo_indexer_status.yml
repo_redirect.yml
repo_topic.yml
repo_transfer.yml Repository transfer has to be confirmed, if user can not create repo for new owner (#14792) 2021-03-01 01:47:30 +01:00
repo_unit.yml fix calReleaseNumCommitsBehind (#24148) (#24197) 2023-04-22 12:30:24 -04:00
repository.yml fix calReleaseNumCommitsBehind (#24148) (#24197) 2023-04-22 12:30:24 -04:00
review.yml Add dismiss review feature (#12674) 2021-02-11 18:32:25 +01:00
star.yml
stopwatch.yml
system_setting.yml Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
team.yml Don't return duplicated users who can create org repo (#22560) 2023-01-30 18:12:45 +08:00
team_repo.yml
team_unit.yml Fix issue overview for teams (#19652) 2022-05-16 17:49:17 +08:00
team_user.yml Don't return duplicated users who can create org repo (#22560) 2023-01-30 18:12:45 +08:00
topic.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
tracked_time.yml
two_factor.yml
user.yml fix calReleaseNumCommitsBehind (#24148) (#24197) 2023-04-22 12:30:24 -04:00
user_open_id.yml
user_redirect.yml Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
watch.yml
webauthn_credential.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
webhook.yml