mirror of
1
Fork 0
forgejo/templates/repo/issue
silverwind e24f651c86
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
2023-06-14 18:17:58 +00:00
..
fields Add validations.required check to dropdown field (#24849) 2023-05-22 21:26:48 +00:00
labels Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
milestone Improve dropdown menus, remove inline styles (#24954) 2023-05-29 14:10:06 +00:00
view_content Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
branch_selector_field.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
choose.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
comment_tab.tmpl Improve markdown editor: width, height, preferred (#23895) 2023-04-07 13:03:29 -04:00
label_precolors.tmpl Fix purple color in suggested label colors (#18241) 2022-01-11 12:11:40 -06:00
labels.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
list.tmpl Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
milestone_issues.tmpl Add Progressbar to Milestone Page (#25050) 2023-06-05 14:25:46 +08:00
milestone_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
milestones.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
navbar.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
new.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
new_form.tmpl Improve dropdown menus, remove inline styles (#24954) 2023-05-29 14:10:06 +00:00
openclose.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
search.tmpl Improve some Forms (#24878) 2023-05-26 09:42:54 +00:00
view.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
view_content.tmpl Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
view_title.tmpl Use flex to align SVG and text (#25163) 2023-06-14 16:40:15 +00:00