mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/web_src/js/features
History
oliverpool 6cef23db1d [BUG] admin oauth2 source required check (#4194) 
#4059 was unfortunately incomplete: some custom_url fields are currently shown, even if they are not used by the provider. Moreover the `Use Custom URLs Instead of Default URLs` is always checked by default.

Manual testing:
- go to http://localhost:3000/admin/auths
- click on `Add authentication source`
- Choose `Authentication type`: `OAuth2`
- Choose `OAuth2 provider`: `GitLab`
- verify that the `Use Custom URLs Instead of Default URLs` option is **initially unchecked**
- enable the `Use Custom URLs Instead of Default URLs` checkbox
- verify that only the fields "Authorize", "Token" and "Profile" URLs are shown (no "Email URL", nor "Tenant").
- Switch the `OAuth2 provider` to `Azure AD v2`
- verify that the `Use Custom URLs Instead of Default URLs` option is **initially checked**
- verify that only the field "Tenant" is shown (with the default "organizations").

![image](/attachments/0e2b1508-861c-4b0e-ae6a-6eb24ce94911)

Note: this is loosely based on the upstream fix https://github.com/go-gitea/gitea/pull/31246 which I initially overlooked.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4194
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
(cherry picked from commit 65f8c22cc7)
 		2024-06-21 06:22:03 +00:00
..
admin [BUG] admin oauth2 source required check (#4194) 2024-06-21 06:22:03 +00:00
comp s/Gitea/Forgejo in various log messages and comments 2024-04-22 14:41:17 +00:00
autofocus-end.js When the title in the issue has a value, set the text cursor at the end of the text. (#30090) 2024-03-30 07:17:31 +01:00
captcha.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
citation.js Remove jQuery from the citation modal (except fomantic) (#30008) 2024-03-26 19:04:27 +01:00
clipboard.js Fix Citation modal responsiveness and clipboard copy (#29799) 2024-03-20 08:46:29 +01:00
code-frequency.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
codeeditor.js Disable enter key for accepting code completion in Monaco (#30548) (#30559) 2024-04-21 18:11:02 +02:00
colorpicker.js Forbid jQuery `.css` and refactor all usage (#29852) 2024-03-26 19:04:25 +01:00
common-global.js Remove fomantic checkbox module (#30162) (#30168) 2024-04-08 11:28:31 +02:00
common-issue-list.js Remove jQuery from the issue "go to" button (#30028) 2024-03-26 19:04:27 +01:00
common-issue-list.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
common-organization.js Fix `initCompLabelEdit` not being called (#29198) 2024-02-17 23:24:31 +01:00
contextpopup.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
contributors.js Fix Activity Page Contributors dropdown (#31264) 2024-06-18 19:42:31 +00:00
copycontent.js Use fetch helpers instead of fetch (#27026) 2023-09-19 00:50:30 +00:00
dropzone.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
emoji.js Update JS and PY dependencies (#27501) 2023-10-08 00:16:20 +00:00
eventsource.sharedworker.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
file-fold.js Update JS dependencies (#27922) 2023-11-06 21:14:32 +00:00
heatmap.js Fix heatmap localization 2024-03-20 08:20:08 +01:00
imagediff.js Remove remaining jQuery .css code (#30015) 2024-03-26 19:04:28 +01:00
install.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
notification.js Migrate `gt-hidden` to `tw-hidden` (#30046) 2024-03-30 07:17:29 +01:00
org-team.js Remove jQuery calls that have no effect on `showElem` and `hideElem` (#30110) 2024-03-30 07:17:30 +01:00
pull-view-file.js Fix counter display number incorrectly displayed on the page (#29448) 2024-03-06 12:10:44 +08:00
recent-commits.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
repo-branch.js Remove jQuery from the create/rename branch modals (except Fomantic) (#30109) 2024-03-30 07:17:31 +01:00
repo-code.js Remove jQuery `.attr` from the code line range selection (#30077) 2024-03-30 07:17:30 +01:00
repo-code.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
repo-commit.js Fix elipsis button not working if the last commit loading is deferred (#29544) 2024-03-06 12:10:46 +08:00
repo-common.js Refactor and fix archive link bug (#30535) 2024-05-14 08:34:46 +02:00
repo-diff-commit.js Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
repo-diff-commitselect.js Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
repo-diff-filetree.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-diff.js Refactor all `.length === 0` patterns in JS (#30045) 2024-03-30 07:17:30 +01:00
repo-editor.js Remove jQuery calls that have no effect on `showElem` and `hideElem` (#30110) 2024-03-30 07:17:30 +01:00
repo-findfile.js Refactor all `.length === 0` patterns in JS (#30045) 2024-03-30 07:17:30 +01:00
repo-findfile.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
repo-graph.js Migrate `gt-hidden` to `tw-hidden` (#30046) 2024-03-30 07:17:29 +01:00
repo-home.js Refactor all `.length === 0` patterns in JS (#30045) 2024-03-30 07:17:30 +01:00
repo-issue-content.js Migrate `gt-hidden` to `tw-hidden` (#30046) 2024-03-30 07:17:29 +01:00
repo-issue-list.js Drag-and-drop improvements for projects and issue pins (#29875) 2024-03-30 07:17:31 +01:00
repo-issue-pr-form.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-issue-pr-status.js Fix the overflow style for "Hide all checks" (#27932) 2023-11-07 18:53:35 +00:00
repo-issue.js Fix an incorrect form submission in repo-issue.js (#3675) 2024-05-08 21:16:08 +00:00
repo-legacy.js [PORT] Refactor dropzone (#30232) 2024-04-08 09:50:53 +00:00
repo-migrate.js Remove jQuery from repo migrate page (#29219) 2024-02-19 22:58:32 +01:00
repo-migration.js Remove jQuery from the repo migration form (#29229) 2024-02-26 21:42:14 +01:00
repo-projects.js Fix various problems around projects board view (#30696) 2024-05-14 15:51:15 +02:00
repo-release.js [FRONTEND] fix javascript linting errors 2024-02-25 23:43:58 +01:00
repo-search.js Filter Repositories by type (#29231) 2024-03-06 12:10:46 +08:00
repo-settings.js Refactor all `.length === 0` patterns in JS (#30045) 2024-03-30 07:17:30 +01:00
repo-template.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
repo-unicode-escape.js [v7.0/forgejo] Render inline file permalinks 2024-04-01 16:15:58 +02:00
repo-wiki.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
sshkey-helper.js Remove jQuery from SSH key form parser (#29193) 2024-02-17 23:24:31 +01:00
stopwatch.js Remove jQuery from the stopwatch (#29351) 2024-02-26 22:30:26 +01:00
tablesort.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
tribute.js Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
user-auth-webauthn.js Enforce trailing comma in JS on multiline (#30002) 2024-03-26 19:04:27 +01:00
user-auth.js Replace more `gt-` with `tw-`, update frontend docs (#29595) 2024-03-11 23:36:58 +07:00
user-settings.js [v7.0/forgejo] Add optional pronoun field in user settings (#3076) 2024-04-06 13:23:43 +00:00