mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/services/convert
History
Jason Song 174213530d
Fix `Permission` in API returned repository struct (#25388) 
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
 		2023-06-22 13:08:08 +00:00
..
activity.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
attachment.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
convert.go add admin API email endpoints (#22792) 2023-03-14 03:54:40 -04:00
git_commit.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
git_commit_test.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
issue.go Add the ability to pin Issues (#24406) 2023-05-25 15:17:19 +02:00
issue_comment.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
issue_test.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
main_test.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
mirror.go Fix SyncOnCommit always return false in API of push_mirrors (#23088) 2023-02-23 15:50:33 -06:00
notification.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
package.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
pull.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
pull_review.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
pull_test.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
release.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
repository.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
status.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
user.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
user_test.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
utils.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
utils_test.go Rewrite queue (#24505) 2023-05-08 19:49:59 +08:00
wiki.go Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00