mirror of
1
Fork 0
forgejo/models/activities
Gusted 3d3790ef4c
[MODERATION] Refactor excluding watchers mechanism (squash)
Backport of #2143

This solves two bugs. One bug is that due to the JOIN with the
`forgejo_blocked_users` table, duplicated users were generated if a user
had more than one user blocked, this lead to receiving more than one
entry in the actions table. The other bug is that if a user blocked more
than one user, it would still receive a action entry by a
blocked user, because the SQL query would not exclude the other
duplicated users that was generated by the JOIN.

The new solution is somewhat non-optimal in my eyes, but it's better
than rewriting the query to become a potential perfomance blocker (usage
of WHERE IN, which cannot be rewritten to a JOIN). It simply removes the
watchers after it was retrieved by the SQL query.

(cherry picked from commit c63c00b39b)
2024-01-22 21:01:08 +01:00
..
action.go [MODERATION] Refactor excluding watchers mechanism (squash) 2024-01-22 21:01:08 +01:00
action_list.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
action_test.go More `db.DefaultContext` refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
main_test.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
notification.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
notification_test.go More `db.DefaultContext` refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
repo_activity.go Quote table `release` in sql queries (#27205) (#27218) 2023-09-23 21:15:05 +00:00
statistic.go Reduce usage of `db.DefaultContext` (#27073) 2023-09-14 17:09:32 +00:00
user_heatmap.go More `db.DefaultContext` refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
user_heatmap_test.go Another round of `db.DefaultContext` refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00