mirror of
1
Fork 0
forgejo/routers/web/repo/setting
Giteabot b8e6cffd31
Preserve BOM in web editor (#28935) (#28959)
Backport #28935 by @silverwind

The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.

Co-authored-by: silverwind <me@silverwind.io>
2024-01-27 23:23:31 +01:00
..
avatar.go Improve hint when uploading a too large avatar (#26935) 2023-09-07 13:35:45 +00:00
collaboration.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
default_branch.go Fix schedule tasks bugs (#28691) (#28780) 2024-01-14 23:54:22 +01:00
deploy_key.go Another round of `db.DefaultContext` refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
git_hooks.go Move some files under repo/setting (#25585) 2023-07-02 08:59:32 +08:00
lfs.go Preserve BOM in web editor (#28935) (#28959) 2024-01-27 23:23:31 +01:00
main_test.go Move some files under repo/setting (#25585) 2023-07-02 08:59:32 +08:00
protected_branch.go Update status and code index after changing the default branch (#27018) 2023-09-13 04:43:31 +00:00
protected_tag.go Move some files under repo/setting (#25585) 2023-07-02 08:59:32 +08:00
runners.go Fix repo count in org action settings (#27245) (#27353) 2023-09-29 20:00:24 +02:00
secrets.go Fix repo count in org action settings (#27245) (#27353) 2023-09-29 20:00:24 +02:00
setting.go Fix schedule tasks bugs (#28691) (#28780) 2024-01-14 23:54:22 +01:00
settings_test.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
variables.go Fix repo count in org action settings (#27245) (#27353) 2023-09-29 20:00:24 +02:00
webhook.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00