mirror of
1
Fork 0
forgejo/modules/templates
silverwind f6c0c39f1a
[PORT] gitea##30237: Fix and rewrite contrast color calculation, fix project-related bugs
1. The previous color contrast calculation function was incorrect at
least for the `#84b6eb` where it output low-contrast white instead of
black. I've rewritten these functions now to accept hex colors and to
match GitHub's calculation and to output pure white/black for maximum
contrast. Before and after:
<img width="94" alt="Screenshot 2024-04-02 at 01 53 46"
src="https://github.com/go-gitea/gitea/assets/115237/00b39e15-a377-4458-95cf-ceec74b78228"><img
width="90" alt="Screenshot 2024-04-02 at 01 51 30"
src="https://github.com/go-gitea/gitea/assets/115237/1677067a-8d8f-47eb-82c0-76330deeb775">

2. Fix project-related issues:

- Expose the new `ContrastColor` function as template helper and use it
for project cards, replacing the previous JS solution which eliminates a
flash of wrong color on page load.
- Fix a bug where if editing a project title, the counter would get
lost.
- Move `rgbToHex` function to color utils.

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io>

---
Conflict resolution: Trivial.
(cherry picked from commit 36887ed3921d03f1864360c95bd2ecf853bfbe72)
2024-04-15 16:11:34 +02:00
..
eval Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
scopedtmpl Replace `interface{}` with `any` (#25686) 2023-07-04 18:36:08 +00:00
vars Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
base.go Replace `util.SliceXxx` with `slices.Xxx` (#26958) 2023-09-07 09:37:47 +00:00
dynamic.go Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
helper.go [PORT] gitea##30237: Fix and rewrite contrast color calculation, fix project-related bugs 2024-04-15 16:11:34 +02:00
helper_test.go Remove unnecessary SanitizeHTML from code (#29575) 2024-03-11 23:36:58 +07:00
htmlrenderer.go Upgrade to golangci-lint@v1.55.0 (#27756) 2023-10-24 02:54:59 +00:00
htmlrenderer_test.go Show friendly 500 error page to users and developers (#24110) 2023-04-14 13:19:11 +08:00
mailer.go Breaking summary for template refactoring (#29395) 2024-03-06 12:10:46 +08:00
main_test.go [BUG] Render correct label link 2024-04-12 17:23:20 +02:00
static.go Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
templates_bindata.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
util_avatar.go Fix default avatar image size in PR diff page (#28971) 2024-02-02 10:01:11 +00:00
util_dict.go Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804) 2023-08-30 06:55:25 +00:00
util_json.go Improve template helper (#24417) 2023-04-29 08:02:29 -04:00
util_misc.go Improve feed icons and feed merge text color (#27498) 2023-10-07 23:26:27 +00:00
util_render.go [PORT] gitea##30237: Fix and rewrite contrast color calculation, fix project-related bugs 2024-04-15 16:11:34 +02:00
util_render_test.go [BUG] Render correct label link 2024-04-12 17:23:20 +02:00
util_slice.go Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00
util_string.go Refactor some Str2html code (#29397) 2024-03-06 12:10:44 +08:00
util_string_test.go templates: HasPrefix support for template.HTML 2024-02-16 15:20:52 +01:00
util_test.go Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00