mirror of
1
Fork 0
forgejo/models/issues
forgejo-backport-action c2158b2a1f [v10.0/forgejo] fix: consider public issues for project boards (#7144)
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/7143

- The security patch of forgejo/forgejo#6843 fixed the issue where project boards loaded all issues without considering if the doer actually had permission to view that issue. Within that patch the call to `Issues` was modified to include this permission checking.
- The query being generated was not entirely correct. Issues in public repositories weren't considered correctly (partly the fault of not setting `AllPublic` unconditionally) in the cause an authenticated user loaded the project.
- This is now fixed by setting `AllPublic` unconditionally and subsequently fixing the `Issue` function to ensure that the combination of setting `AllPublic` and `User` generates the correct query, by combining the permission check and issues in public repositories as one `AND` query.
- Added unit testing.
- Added integration testing.
- Resolves Codeberg/Community#1809
- Regression of https://codeberg.org/forgejo/forgejo/pulls/6843

Co-authored-by: Gusted <postmaster@gusted.xyz>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7144
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
2025-03-07 00:51:07 +00:00
..
TestGetUIDsAndStopwatch fix: use better code to group UID and stopwatches 2024-11-16 15:59:02 +01:00
assignees.go Performance improvements for pull request list API (#30490) 2024-06-02 16:26:54 +02:00
assignees_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
comment.go Strict pagination check (#32548) 2024-12-01 07:56:45 +01:00
comment_code.go Do some performance optimize for issues list and view issue/pull (gitea#29515) 2024-04-08 14:47:31 +02:00
comment_list.go fix: never set Poster or Assignee to nil 2024-07-29 15:24:02 +02:00
comment_list_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
comment_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
content_history.go [BUG] Ensure `HasIssueContentHistory` takes into account `comment_id` 2024-02-29 18:23:06 +01:00
content_history_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
dependency.go
dependency_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue.go [v10.0/forgejo] feat: Add summary card for repos and releases 2025-01-01 22:00:26 +01:00
issue_index.go Do not update PRs based on events that happened before they existed 2024-04-11 11:16:23 +02:00
issue_index_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue_label.go chore(refactor): split ReloadLabels out of LoadLabels in issue model 2024-11-07 11:05:38 +01:00
issue_label_test.go chore(refactor): split ReloadLabels out of LoadLabels in issue model 2024-11-07 11:05:38 +01:00
issue_list.go fix: never set Poster or Assignee to nil 2024-07-29 15:24:02 +02:00
issue_list_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue_lock.go
issue_project.go [v10.0/forgejo] fix: consider public issues for project boards (#7144) 2025-03-07 00:51:07 +00:00
issue_project_test.go [v10.0/forgejo] fix: consider public issues for project boards (#7144) 2025-03-07 00:51:07 +00:00
issue_search.go [v10.0/forgejo] fix: consider public issues for project boards (#7144) 2025-03-07 00:51:07 +00:00
issue_stats.go [Feat]Add link to show all Issues/PullRequests (#4125) 2024-10-09 04:56:40 +00:00
issue_stats_test.go [Feat]Add link to show all Issues/PullRequests (#4125) 2024-10-09 04:56:40 +00:00
issue_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue_update.go Trim title before insert/update to database to match the size requirements of database (#32498) 2024-11-17 12:18:56 +01:00
issue_user.go
issue_user_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue_watch.go Strict pagination check (#32548) 2024-12-01 07:56:45 +01:00
issue_watch_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
issue_xref.go
issue_xref_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
label.go Support org labels when adding labels by label names (#32988) 2024-12-30 08:26:54 +00:00
label_test.go refactor: remove redundant err declarations (#32381) 2024-11-05 09:33:15 +01:00
main_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
milestone_list.go [PORT] Added default sorting milestones by name (gitea#27084) 2024-07-22 14:55:58 +02:00
milestone_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
pull.go Trim title before insert/update to database to match the size requirements of database (#32498) 2024-11-17 12:18:56 +01:00
pull_list.go Allow filtering PRs by poster in the ListPullRequests API (#32209) 2024-10-13 07:58:01 +03:00
pull_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
reaction.go Strict pagination check (#32548) 2024-12-01 07:56:45 +01:00
reaction_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
review.go Fix the logic of finding the latest pull review commit ID (#32139) 2024-10-06 07:44:28 +02:00
review_list.go Fix the logic of finding the latest pull review commit ID (#32139) 2024-10-06 07:44:28 +02:00
review_test.go Fix the logic of finding the latest pull review commit ID (#32139) 2024-10-06 07:44:28 +02:00
stopwatch.go Strict pagination check (#32548) 2024-12-01 07:56:45 +01:00
stopwatch_test.go fix: use better code to group UID and stopwatches 2024-11-16 15:59:02 +01:00
tracked_time.go Strict pagination check (#32548) 2024-12-01 07:56:45 +01:00
tracked_time_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00