mirror of
1
Fork 0
forgejo/modules/repository
Jason Song 477a1cc40e
Improve utils of slices (#22379)
- Move the file `compare.go` and `slice.go` to `slice.go`.
- Fix `ExistsInSlice`, it's buggy
  - It uses `sort.Search`, so it assumes that the input slice is sorted.
- It passes `func(i int) bool { return slice[i] == target })` to
`sort.Search`, that's incorrect, check the doc of `sort.Search`.
- Conbine `IsInt64InSlice(int64, []int64)` and `ExistsInSlice(string,
[]string)` to `SliceContains[T]([]T, T)`.
- Conbine `IsSliceInt64Eq([]int64, []int64)` and `IsEqualSlice([]string,
[]string)` to `SliceSortedEqual[T]([]T, T)`.
- Add `SliceEqual[T]([]T, T)` as a distinction from
`SliceSortedEqual[T]([]T, T)`.
- Redesign `RemoveIDFromList([]int64, int64) ([]int64, bool)` to
`SliceRemoveAll[T]([]T, T) []T`.
- Add `SliceContainsFunc[T]([]T, func(T) bool)` and
`SliceRemoveAllFunc[T]([]T, func(T) bool)` for general use.
- Add comments to explain why not `golang.org/x/exp/slices`.
- Add unit tests.
2023-01-11 13:31:16 +08:00
..
collaborator.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
collaborator_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
commits.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
commits_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
create.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
create_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
delete.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
env.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fork.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
generate.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
generate_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hooks.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
init.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
push.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
temp.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00